62903[TASK] Add test cases for handling of l18n_cfg field in pages sitemap
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/frontend/Classes/Page/PageRepository.php+1 −1
- typo3/sysext/seo/Tests/Functional/Fixtures/pages-sitemap.xml+26 −0
- typo3/sysext/seo/Tests/Functional/XmlSitemap/AbstractXmlSitemapPagesTest.phpnew+74 −0
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php+46 −64
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesWithHideIfNotTranslatedTest.phpnew+92 −0
Review log 57
-
Benni Mack commented on patch set 1 01/14/20, 20:01
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Domain/Repository/PageRepository.php * typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php -
TYPO3com voted on patch set 1 V -1 01/14/20, 20:02 Completed build in 54s on Tue, 14 Jan, 08:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1826
-
Benni Mack uploaded patch set 2 01/14/20, 20:21
-
Benni Mack commented on patch set 2 01/14/20, 20:21
This change is ready for review. -
TYPO3com voted on patch set 2 V +1 01/14/20, 20:41 Completed build in 19m 51s on Tue, 14 Jan, 08:41 PM Test Summary: 73088 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1827
-
Benni Mack voted on patch set 2 V +2 CR +2 01/14/20, 20:45
-
Benni Mack merged patch set 3 01/14/20, 20:45