Review 9.5 Merged

62903[TASK] Add test cases for handling of l18n_cfg field in pages sitemap

Benni Mack CR +2 V +2 Hard +239 −65 updated 01/14/20, 20:45

Commit message

The patch also adds tests for the behavior with
$GLOBALS['TYPO3_CONF_VARS']['FE']['hidePagesIfNotTranslatedByDefault']
enabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 57

  1. Benni Mack commented on patch set 1 01/14/20, 20:01

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Domain/Repository/PageRepository.php * typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php
  2. TYPO3com voted on patch set 1 V -1 01/14/20, 20:02 Completed build in 54s on Tue, 14 Jan, 08:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1826

  3. Benni Mack uploaded patch set 2 01/14/20, 20:21

  4. Benni Mack commented on patch set 2 01/14/20, 20:21

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 01/14/20, 20:41 Completed build in 19m 51s on Tue, 14 Jan, 08:41 PM Test Summary: 73088 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1827

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/14/20, 20:45

  7. Benni Mack merged patch set 3 01/14/20, 20:45