Review 9.5 Merged

62909[BUGFIX] Avoid creation of duplicate processed files

Benni Mack CR +2 V +2 Easy +8 −0 updated 01/15/20, 15:24

Commit message

Processed images are built based on a processing configuration,
which could contain values for width/height and other properties
which are integers (like width: 250, but width: 250c is also allowed).

Pure numeric (int) values are converted to real integers so the processing
configuration is always the same when querying the database for
existing processed files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 01/15/20, 14:41

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php
  2. Benni Mack commented on patch set 2 01/15/20, 14:41

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 2 01/15/20, 14:41

    This change is ready for review.
  4. TYPO3com voted on patch set 1 V -1 01/15/20, 14:58 Completed build in 32s on Wed, 15 Jan, 02:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1838

  5. TYPO3com voted on patch set 2 V +1 01/15/20, 15:22 Completed build in 24m 16s on Wed, 15 Jan, 03:22 PM Test Summary: 73094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1839

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/15/20, 15:24

  7. Benni Mack merged patch set 3 01/15/20, 15:24