Review main Merged

62912[BUGFIX] Avoid creation of duplicate processed files

Benni Mack CR +2 V +2 Easy +8 −0 updated 01/15/20, 14:40

Commit message

Processed images are built based on a processing configuration,
which could contain values for width/height and other properties
which are integers (like width: 250, but width: 250c is also allowed).

Pure numeric (int) values are converted to real integers so the processing
configuration is always the same when querying the database for
existing processed files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Tobi Kretschmann +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Tobi Kretschmann +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 01/15/20, 12:32

  2. TYPO3com voted on patch set 1 V +1 01/15/20, 12:46 Completed build in 11m 27s on Wed, 15 Jan, 12:46 PM Test Summary: 69527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39968

  3. Tobi Kretschmann voted on patch set 1 CR +1 01/15/20, 13:53

  4. Susi Moog voted on patch set 1 CR +1 01/15/20, 14:17

  5. Susi Moog voted on patch set 1 V +1 01/15/20, 14:20

  6. Tobi Kretschmann voted on patch set 1 V +1 01/15/20, 14:30

  7. Benni Mack voted on patch set 1 V +2 CR +2 01/15/20, 14:40

  8. Benni Mack merged patch set 2 01/15/20, 14:40