Review main Merged

62913[FEATURE] Add support for Kinyarwanda language

Tymoteusz Motylewski CR +2 V +2 Easy +29 −0 updated 01/15/20, 16:27

Commit message

Kinyarwanda is an official language of Rwanda,
which is now supported natively in TYPO3 for any
kind of labels with the ISO-839-1 code "rw".

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1217

  1. Tymoteusz Motylewski uploaded patch set 1 01/15/20, 13:31

  2. Georg Ringer voted on patch set 1 V +1 CR +1 01/15/20, 13:32

  3. TYPO3com voted on patch set 1 V +1 01/15/20, 13:43 Completed build in 11m 27s on Wed, 15 Jan, 01:43 PM Test Summary: 69527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39970

  4. Tymoteusz Motylewski uploaded patch set 2 01/15/20, 14:03

  5. TYPO3com voted on patch set 2 V +1 01/15/20, 14:37 Completed build in 21m 07s on Wed, 15 Jan, 02:37 PM Test Summary: 69527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39978

  6. Benni Mack updated the commit message in patch set 3 01/15/20, 15:27

  7. Benni Mack commented on patch set 4 01/15/20, 15:30

    Published edit on patch set 3.
  8. Benni Mack commented on patch set 4 01/15/20, 15:32

    Sorry, I had to adapt the RST etc. This feature is not just for Backend! Please always remember that supporting a new language natively is AWESOME and one could work with TYPO3 now for backend and frontend labels supporting this (it's not just about language packs).
  9. Benni Mack voted on patch set 4 V +1 CR +1 01/15/20, 15:33

  10. TYPO3com voted on patch set 3 V -1 01/15/20, 15:46 Completed build in 18m 49s on Wed, 15 Jan, 03:46 PM Test Summary: 10 of 69977 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39984

  11. TYPO3com voted on patch set 4 V -1 01/15/20, 15:49 Completed build in 16m 31s on Wed, 15 Jan, 03:49 PM Test Summary: 8 of 69978 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39985

  12. Tymoteusz Motylewski commented on patch set 4 01/15/20, 15:50

    thanks Benni!
  13. TYPO3com voted on patch set 4 V +1 01/15/20, 15:57 Completed build in 41m 24s on Wed, 15 Jan, 03:57 PM Test Summary: 69527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39985

  14. Anja Leichsenring voted on patch set 4 V +1 CR +1 01/15/20, 16:03

  15. Daniel Goerz voted on patch set 4 CR +1 01/15/20, 16:15

  16. Daniel Goerz voted on patch set 4 V +2 CR +2 01/15/20, 16:26

  17. Daniel Goerz merged patch set 5 01/15/20, 16:27