Review main Merged

62918[BUGFIX] Remove dependency check on openSSL

Benni Mack CR +2 V +2 Easy +8 −41 updated 01/16/20, 10:10

Commit message

OpenSSL was only needed for EXT:rsaauth,
so a check in the installer / system maintenance
should be avoided. It is now rather a suggestion.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • Felix P. +1
    • Susi Moog +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1113

  1. Benni Mack uploaded patch set 1 01/15/20, 17:42

  2. TYPO3com voted on patch set 1 V -1 01/15/20, 17:59 Completed build in 17m 29s on Wed, 15 Jan, 05:59 PM Test Summary: 1 of 70788 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39993

  3. TYPO3com voted on patch set 1 V +1 01/15/20, 18:04 Completed build in 40m 02s on Wed, 15 Jan, 06:04 PM Test Summary: 70337 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39993

  4. Oliver Klee voted on patch set 1 CR +1 01/15/20, 19:07

  5. Georg Ringer commented on patch set 1 01/15/20, 19:08

    composer.json:89

    should we mention rsaauth if this is not part of the core anymore? looks strange
  6. Susi Moog voted on patch set 1 V +1 CR +1 01/15/20, 21:15

  7. Steffen Frese voted on patch set 1 V +1 CR +1 01/16/20, 07:54

  8. Tobi Kretschmann voted on patch set 1 CR +1 01/16/20, 08:11

  9. Benni Mack commented on patch set 1 01/16/20, 08:30

    composer.json:89 Reply Unresolved

    yeah, I thought bout that too. The main reason why I fixed this because some things were unclear when upgrading without RSA auth. I think it's OK to mention what you can do with that. We can remove it in TYPO3 v11.
  10. Jörg Bösche voted on patch set 1 CR +1 01/16/20, 08:33

  11. Felix P. voted on patch set 1 CR +1 01/16/20, 08:43

  12. Georg Ringer voted on patch set 1 V +2 CR +2 01/16/20, 10:10

  13. Georg Ringer merged patch set 2 01/16/20, 10:10