Review main Merged

62920[BUGFIX] Avoid applying zero prefix for zero in StaticRangeMapper

Oliver Hader CR +2 V +2 Easy +27 −2 updated 01/16/20, 09:59

Commit message

Range from '01' to '03' correctly leads to ['01','02','03']. The
prefix mechanism is however applied for a range from '0' to '11'.
This should only happen when explicitly having used '00' to '11'.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Tobi Kretschmann +1
    • Markus Klein +1
    • Felix P. +1
  • Verified V +2 Done
    • Susi Moog +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Oliver Hader uploaded patch set 1 01/15/20, 20:20

  2. TYPO3com voted on patch set 1 V -1 01/15/20, 20:47 Completed build in 27m 00s on Wed, 15 Jan, 08:47 PM Test Summary: 4 of 70800 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39997

  3. TYPO3com voted on patch set 1 V +1 01/15/20, 21:08 Completed build in 1h 15m 01s on Wed, 15 Jan, 09:08 PM Test Summary: 70349 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39997

  4. Susi Moog voted on patch set 1 CR +1 01/15/20, 21:10

  5. Markus Klein voted on patch set 1 V +1 CR +1 01/16/20, 07:46

  6. Tobi Kretschmann voted on patch set 1 CR +1 01/16/20, 08:38

  7. Felix P. voted on patch set 1 CR +1 01/16/20, 09:07

  8. Daniel Goerz voted on patch set 1 CR +1 01/16/20, 09:15

  9. Susi Moog voted on patch set 1 V +1 01/16/20, 09:59

  10. Susi Moog voted on patch set 1 V +2 CR +2 01/16/20, 09:59

  11. Susi Moog merged patch set 2 01/16/20, 09:59