Review main Merged

62929[BUGFIX] Prevent ambiguous column name for TCA items

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 01/16/20, 12:07

Commit message

When fetching items from foreign table, they might be sorted based on
foreign table configured sorting. In such case the foreign table name is
prefixed to prevent ambiguous column name.

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Daniel Goerz +1
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • Felix P. +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1214

  1. Daniel Siepmann uploaded patch set 1 01/16/20, 10:26

  2. Benni Mack commented on patch set 1 01/16/20, 10:29

    The original change needs to go in 9.5 as well.
  3. Benni Mack updated the commit message in patch set 2 01/16/20, 10:29

  4. Benni Mack updated the commit message in patch set 3 01/16/20, 10:29

  5. Felix P. voted on patch set 3 CR +1 01/16/20, 11:01

  6. Tobi Kretschmann voted on patch set 3 V +1 CR +1 01/16/20, 11:07

  7. Jörg Bösche voted on patch set 3 V +1 CR +1 01/16/20, 11:14

  8. TYPO3com voted on patch set 1 V +1 01/16/20, 11:15 Completed build in 31m 44s on Thu, 16 Jan, 11:15 AM Test Summary: 70373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40021

  9. Daniel Goerz voted on patch set 3 CR +1 01/16/20, 11:25

  10. TYPO3com voted on patch set 3 V +1 01/16/20, 11:47 Completed build in 1h 02m 51s on Thu, 16 Jan, 11:47 AM Test Summary: 70373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40023

  11. Sascha Rademacher voted on patch set 3 CR +1 01/16/20, 11:47

  12. Sascha Rademacher voted on patch set 3 V +1 01/16/20, 12:06

  13. Tobi Kretschmann voted on patch set 3 V +2 CR +2 01/16/20, 12:07

  14. Tobi Kretschmann merged patch set 4 01/16/20, 12:07