Review 9.5 Merged

62942[BUGFIX] Use latest slug in PopulatePageSlug

Frank Nägler CR +2 V +2 Easy +1 −1 updated 01/17/20, 15:04

Commit message

PopulatePageSlug is an upgrade wizard which migrates existing slugs
from realurl tables to the table pages.slug.

In realurl, when the page title changed, the realurl slug changed
(if not fixed). Realurl handled this by adding temporary entries to
its tables which would be used to redirect the URL to its new location.
These entries had a fixed expiration date (expire > 0). The final
slug had no expiration date (expire = 0)

The previous behaviour in PopulatePageSlug preferred entries from
tx_realurl_pathdata with an expiration date (expire > 0) over
entries without (expire = 0). This would prefer (temporary) entries
that were only used for the redirects over the final slug.

This patch uses the 'uid' for sorting in descending order, which
will always use the latest entry for a specific page / language
combinations.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 34

  1. Frank Nägler commented on patch set 1 01/17/20, 14:42

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/17/20, 14:54 Completed build in 11m 12s on Fri, 17 Jan, 02:54 PM Test Summary: 73118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1873

  3. Frank Nägler voted on patch set 1 V +2 CR +2 01/17/20, 15:03

  4. Frank Nägler merged patch set 2 01/17/20, 15:04