Review 9.5 Merged

62944[TASK] Do not add target attribute if lightbox is enabled

Benni Mack CR +2 V +2 Easy +22 −6 updated 01/17/20, 17:48

Commit message

If config.fileTarget is set, per example to "_blank", the target is
set as fallbak on file link. The target is also added on click enlarge
link but it is not wanted if lightbox is enabled.

This patch ensure that the target attribute is not printed when
lightbox is enabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 01/17/20, 17:14

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/17/20, 17:25 Completed build in 10m 41s on Fri, 17 Jan, 05:25 PM Test Summary: 73118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1875

  3. Benni Mack voted on patch set 1 V +2 CR +2 01/17/20, 17:46

  4. Benni Mack merged patch set 2 01/17/20, 17:48