Review main Merged

62955[BUGFIX] Respect cross-site error content source

Francois Suter CR +2 V +2 Easy +14 −4 updated 03/02/20, 10:23

Commit message

In a multi-site setup, it should be possible to refer to a page
from site A as an error page from site B.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1015

  1. Francois Suter uploaded patch set 1 01/17/20, 10:24

  2. TYPO3com voted on patch set 1 V -1 01/17/20, 10:33 Completed build in 08m 57s on Fri, 17 Jan, 10:33 AM Test Summary: 70140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40060

  3. TYPO3com voted on patch set 1 V +1 01/17/20, 10:46 Completed build in 30m 25s on Fri, 17 Jan, 10:46 AM Test Summary: 70442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40060

  4. Francois Suter rebased onto patch set 2 02/05/20, 08:06

  5. Susi Moog rebased onto patch set 3 02/28/20, 07:02

  6. TYPO3com voted on patch set 3 V +1 02/28/20, 07:16 Completed build in 13m 10s on Fri, 28 Feb, 07:16 AM Test Summary: 72003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-765

  7. Susi Moog voted on patch set 3 CR +1 02/29/20, 19:15

  8. Susi Moog uploaded patch set 4 02/29/20, 19:22

  9. Susi Moog commented on patch set 4 V +1 CR +1 02/29/20, 19:23

    just used \InvalidArgument instead of \Exception as that is what is actually thrown in the language method.
  10. TYPO3com voted on patch set 4 V -1 02/29/20, 19:33 Completed build in 10m 24s on Sat, 29 Feb, 07:33 PM Test Summary: 61810 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-877

  11. Oli Bartsch voted on patch set 4 CR +1 02/29/20, 19:39

  12. TYPO3com voted on patch set 4 V +1 02/29/20, 19:41 Completed build in 29m 21s on Sat, 29 Feb, 07:41 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-877

  13. Benni Mack voted on patch set 4 V +2 CR +2 03/02/20, 08:44

  14. Benni Mack merged patch set 5 03/02/20, 08:44

  15. Francois Suter commented on patch set 5 03/02/20, 10:23

    Thanks for taking care!