Review TYPO3_8-7 Merged

62982[TASK] Update copyright year in several files to 2020

Benni Mack CR +2 V +2 Easy +21 −21 updated 01/29/20, 15:00

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Elias Häußler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Elias Häußler +1
    • TYPO3com +1 CI

Issues 1

Files 21

Review log 1117

  1. Benni Mack commented on patch set 1 01/28/20, 17:20

    Cherry Picked from branch 9.5. The following files contain Git conflicts: * INSTALL.md * typo3/sysext/seo/Documentation/Index.rst * typo3/sysext/seo/Documentation/Settings.cfg
  2. Benni Mack commented on patch set 2 01/28/20, 17:20

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 3 01/28/20, 17:20

    Published edit on patch set 2.
  4. Benni Mack commented on patch set 3 01/28/20, 17:20

    This change is ready for review.
  5. Elias Häußler voted on patch set 3 V +1 CR +1 01/28/20, 17:25

  6. TYPO3com voted on patch set 3 V -1 01/28/20, 17:28 Completed build in 07m 33s on Tue, 28 Jan, 05:28 PM Test Summary: 354 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3840

  7. TYPO3com voted on patch set 2 V -1 01/28/20, 17:31 Completed build in 09m 57s on Tue, 28 Jan, 05:31 PM Test Summary: 9897 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3839

  8. TYPO3com voted on patch set 1 V -1 01/28/20, 17:31 Completed build in 10m 09s on Tue, 28 Jan, 05:31 PM Test Summary: 79647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3838

  9. TYPO3com commented on patch set 3 01/28/20, 17:40 Completed build in 27m 03s on Tue, 28 Jan, 05:40 PM Test Summary: 92141 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3840

  10. TYPO3com commented on patch set 3 01/29/20, 07:39 Completed build in 12m 15s on Wed, 29 Jan, 07:39 AM Test Summary: 80254 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3841

  11. TYPO3com voted on patch set 3 V +1 01/29/20, 08:13 Completed build in 58m 56s on Wed, 29 Jan, 08:13 AM Test Summary: 101774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3841

  12. Benni Mack voted on patch set 3 V +2 CR +2 01/29/20, 08:36

  13. Benni Mack merged patch set 4 01/29/20, 08:36

  14. Benni Mack commented on patch set 4 01/29/20, 13:44

    > Patch Set 4: > > https://github.com/TYPO3/TYPO3.CMS/blob/v8.7.30/typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php#L88 > > see https://review.typo3.org/c/Packages/TYPO3.CMS/+/55881 (In 9.5 we have date('Y') here) Can you elaborate? This is just updates on docs, for PHP this is all taken care of.
  15. Guido Schmechel commented on patch set 4 01/29/20, 14:23

    - We have the file SystemEnvironmentBuilder.php in the 8_7 branch which contains "2019". (See Github Link) - 9.5 removes this fix year and change it to date('Y') -> all fine - master have a new copyright class -> all fine Conclusion: We have a separate todo for the 8_7 branch. Hopefully this is more clear?
  16. Benni Mack commented on patch set 4 01/29/20, 15:00

    > Patch Set 4: > > - We have the file SystemEnvironmentBuilder.php in the 8_7 branch which contains "2019". (See Github Link) > - 9.5 removes this fix year and change it to date('Y') -> all fine > - master have a new copyright class -> all fine > > Conclusion: We have a separate todo for the 8_7 branch. Hopefully this is more clear? AAAAAH. Thanks for this info! Separate patch, will take care!