Review main Merged

62994[BUGFIX] Consider Symfony route modifier

Oliver Hader CR +2 V +2 Normal +109 −43 updated 01/20/20, 15:56

Commit message

Symfony route modifiers like `{!parameter}` were not encapsulated
when preparing TYPO3 specific enhancer data for route processing.
Internal static MD5 hashing is reduced by 4 bits (one character
when hex encoded) to keep route modifier in deflated values.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 711

  1. Oliver Hader uploaded patch set 1 01/19/20, 14:15

  2. TYPO3com voted on patch set 1 V -1 01/19/20, 14:16 Completed build in 17s on Sun, 19 Jan, 02:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40088

  3. Oliver Hader updated the commit message in patch set 2 01/19/20, 14:16

  4. TYPO3com voted on patch set 2 V -1 01/19/20, 14:17 Completed build in 17s on Sun, 19 Jan, 02:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40089

  5. Oliver Hader uploaded patch set 3 01/19/20, 14:19

  6. TYPO3com voted on patch set 3 V +1 01/19/20, 14:29 Completed build in 09m 56s on Sun, 19 Jan, 02:29 PM Test Summary: 70484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40090

  7. Oliver Hader uploaded patch set 4 01/19/20, 14:47

  8. TYPO3com voted on patch set 4 V +1 01/19/20, 14:59 Completed build in 11m 13s on Sun, 19 Jan, 02:59 PM Test Summary: 70493 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40092

  9. Benni Mack voted on patch set 4 CR +1 01/20/20, 11:27

  10. Oliver Hader voted on patch set 4 V +2 CR +2 01/20/20, 15:56

  11. Oliver Hader merged patch set 5 01/20/20, 15:56