Review 9.5 Merged

62995[BUGFIX] Consider Symfony route modifier

Oliver Hader CR +2 V +2 Normal +109 −43 updated 01/20/20, 15:56

Commit message

Symfony route modifiers like `{!parameter}` were not encapsulated
when preparing TYPO3 specific enhancer data for route processing.
Internal static MD5 hashing is reduced by 4 bits (one character
when hex encoded) to keep route modifier in deflated values.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 812

  1. Oliver Hader uploaded patch set 1 01/19/20, 14:25

  2. Oliver Hader voted on patch set 1 CR -1 01/19/20, 14:26

  3. Oliver Hader uploaded patch set 2 01/19/20, 14:35

  4. TYPO3com voted on patch set 1 V -1 01/19/20, 14:36 Completed build in 10m 54s on Sun, 19 Jan, 02:36 PM Test Summary: 42 of 73760 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1883

  5. Oliver Hader commented on patch set 2 CR -1 01/19/20, 14:37

    waiting for patch in master
  6. TYPO3com voted on patch set 2 V -1 01/19/20, 14:46 Completed build in 10m 19s on Sun, 19 Jan, 02:46 PM Test Summary: 73160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1884

  7. Oliver Hader uploaded patch set 3 01/19/20, 14:49

  8. Oliver Hader commented on patch set 3 CR -1 01/19/20, 14:49

    waiting for patch in master
  9. TYPO3com voted on patch set 2 V +1 01/19/20, 14:49 Completed build in 24m 27s on Sun, 19 Jan, 02:49 PM Test Summary: 73160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1884

  10. TYPO3com voted on patch set 3 V +1 01/19/20, 15:01 Completed build in 11m 26s on Sun, 19 Jan, 03:01 PM Test Summary: 73169 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1885

  11. Oliver Hader voted on patch set 3 V +2 CR +2 01/20/20, 15:56

  12. Oliver Hader merged patch set 4 01/20/20, 15:56