Review main Merged

62997[TASK] Extend route enhancer test framework

Oliver Hader CR +2 V +2 Normal +202 −45 updated 01/20/20, 14:16

Commit message

+ introduces ApplicableConjunction and corresponding handling
+ introduces defined state check on variables (not-null variables)
+ adds possibility to merge with existing enhancer declaration
+ adjusts VariableItem to support scalar values as well
+ adds human readable output for empty string and null values

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 46

  1. Oliver Hader uploaded patch set 1 01/20/20, 08:14

  2. TYPO3com voted on patch set 1 V +1 01/20/20, 08:23 Completed build in 09m 34s on Mon, 20 Jan, 08:23 AM Test Summary: 70472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40097

  3. Oliver Hader uploaded patch set 2 01/20/20, 09:22

  4. TYPO3com voted on patch set 2 V +1 01/20/20, 09:40 Completed build in 17m 50s on Mon, 20 Jan, 09:40 AM Test Summary: 70490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40104

  5. Oliver Hader voted on patch set 2 V +2 CR +2 01/20/20, 14:16

  6. Oliver Hader merged patch set 3 01/20/20, 14:16