Review main Merged

62999[BUGFIX] Ensure ZipService->extract sets proper permissions

Benni Mack CR +2 V +2 Easy +35 −3 updated 01/24/20, 18:17

Commit message

The extension manager now extracts an uploaded file + folder
and sets the configured permissions again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Benni Mack uploaded patch set 1 01/20/20, 08:26

  2. TYPO3com voted on patch set 1 V +1 01/20/20, 08:38 Completed build in 11m 59s on Mon, 20 Jan, 08:38 AM Test Summary: 70490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40099

  3. Andreas Kienast voted on patch set 1 CR +1 01/20/20, 08:45

  4. Benni Mack uploaded patch set 2 01/20/20, 08:46

  5. Benni Mack commented on patch set 2 01/20/20, 08:47

    Added tests, but vfsstream fails due to GeneralUtility::fixPermissions and "isAbsPath()"
  6. Benni Mack uploaded patch set 3 01/20/20, 08:52

  7. Benni Mack commented on patch set 3 01/20/20, 08:53

    This is a regression from the security release. The changes within GeneralUtility are made so vfsStream tests can set permissions
  8. TYPO3com voted on patch set 2 V -1 01/20/20, 08:56 Completed build in 09m 24s on Mon, 20 Jan, 08:55 AM Test Summary: 3 of 70932 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40100

  9. TYPO3com voted on patch set 3 V +1 01/20/20, 09:02 Completed build in 10m 27s on Mon, 20 Jan, 09:02 AM Test Summary: 70493 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40101

  10. Andreas Kienast voted on patch set 3 CR +1 01/20/20, 09:04

  11. Susi Moog voted on patch set 3 CR +1 01/24/20, 16:57

  12. Frank Nägler voted on patch set 3 V +1 CR +1 01/24/20, 17:56

  13. Andreas Kienast voted on patch set 3 V +2 CR +2 01/24/20, 18:17

  14. Andreas Kienast merged patch set 4 01/24/20, 18:17