Review main Merged

63001[BUGFIX] IP locking: Handle IP stack switch without PHP error

Timo Poppinga CR +2 V +2 Easy +1 −1 updated 01/22/20, 10:36

Commit message

Adjust the IP validation to avoid a warning in case the IP stack
used by the current user has changed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Timo Poppinga uploaded patch set 1 01/20/20, 08:59

  2. TYPO3com voted on patch set 1 V -1 01/20/20, 09:12 Completed build in 12m 03s on Mon, 20 Jan, 09:12 AM Test Summary: 70489 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40103

  3. Markus Klein commented on patch set 1 01/20/20, 11:34

    Thanks Timo! If you don't mind, I will adjust the commit message slightly to match our requirements.
  4. Markus Klein updated the commit message in patch set 2 01/20/20, 11:36

  5. TYPO3com voted on patch set 2 V -1 01/20/20, 11:47 Completed build in 10m 54s on Mon, 20 Jan, 11:47 AM Test Summary: 70191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40110

  6. TYPO3com voted on patch set 2 V +1 01/20/20, 12:07 Completed build in 42m 25s on Mon, 20 Jan, 12:07 PM Test Summary: 70493 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40110

  7. Markus Klein voted on patch set 2 V +1 CR +1 01/20/20, 12:15

  8. Richard Haeser voted on patch set 2 CR +1 01/21/20, 19:58

  9. Georg Ringer voted on patch set 2 V +2 CR +2 01/22/20, 07:51

  10. Georg Ringer merged patch set 3 01/22/20, 07:51

  11. Markus Klein commented on patch set 3 01/22/20, 10:36

    I just realized we have IPv6 support only in v10, so the backport is lapsed