Review main Merged

63003[BUGFIX] Allow CSH details for extbase based FlexForms

Stefan Froemken CR +2 V +2 Easy +0 −21 updated 02/15/20, 08:20

Commit message

In case of extbase many FlexForm fields are called
settings.*. As "settings" is part of the field it
should not be removed as extra identifier.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Froemken uploaded patch set 1 01/20/20, 15:31

  2. Stefan Froemken commented on patch set 1 01/20/20, 15:35

    I have tested it for simple tt_content column without "settings.*", with a CType where pi_flexform is activated without "settings.*" and with CType (list) with "settings.*". Do you know any more situations which should be tested?
  3. TYPO3com voted on patch set 1 V +1 01/20/20, 15:41 Completed build in 09m 55s on Mon, 20 Jan, 03:41 PM Test Summary: 70493 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40115

  4. Stefan Froemken commented on patch set 1 01/20/20, 15:45

    Added some notes to the old code.

    HelpController.php:154 Unresolved

    This breaks, as $field is a string.

    HelpController.php:160 Unresolved

    As you see $field can not be an array.

    HelpController.php:160 Unresolved

    In case of FlexForm there is no $GLOBALS['TCA']['flexform_identifier']. So we have the next error here, because of strpos on NULL.
  5. Benni Mack commented on patch set 1 V +1 CR +1 02/15/20, 07:49

    Thanks, Stefan, for providing this solution!
  6. Georg Ringer voted on patch set 1 V +2 CR +2 02/15/20, 08:19

  7. Georg Ringer merged patch set 2 02/15/20, 08:20