63004[BUGFIX] Prevent overriding ckeditor config from plugins
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Susi Moog +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2533
Show 68 earlier messages
-
Benjamin Kott uploaded patch set 1 01/20/20, 23:04
-
Benjamin Kott commented on patch set 1 CR -1 01/20/20, 23:10
needs testing needs important rst / feature rst something blindly written ;) -
TYPO3com voted on patch set 1 V +1 01/20/20, 23:13 Completed build in 09m 06s on Mon, 20 Jan, 11:13 PM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40117
-
Benjamin Kott uploaded patch set 2 01/20/20, 23:17
-
Benjamin Kott commented on patch set 2 V -1 CR -1 01/20/20, 23:18
needs testing needs important rst / feature rst something blindly written, found first bug while brushing my teeth -
TYPO3com voted on patch set 2 V +1 01/20/20, 23:27 Completed build in 09m 15s on Mon, 20 Jan, 11:27 PM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40118
-
Benjamin Kott uploaded patch set 3 01/21/20, 11:11
-
Benjamin Kott uploaded patch set 4 01/21/20, 11:12
-
Benjamin Kott uploaded patch set 5 01/21/20, 11:13
-
TYPO3com voted on patch set 3 V +1 01/21/20, 11:24 Completed build in 12m 23s on Tue, 21 Jan, 11:24 AM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40120
-
TYPO3com voted on patch set 4 V +1 01/21/20, 11:31 Completed build in 17m 22s on Tue, 21 Jan, 11:31 AM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40121
-
TYPO3com voted on patch set 5 V +1 01/21/20, 11:32 Completed build in 18m 12s on Tue, 21 Jan, 11:32 AM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40122
-
Rémy DANIEL commented on patch set 5 01/21/20, 14:41
RichTextElement.php:189If $configuration[$configName] exists before, it may not be an array. This triggers a warning. Either: - we allow the override of entire array and scalar - it is not allowed to overwrite an existing configuration and an exception should rise and advices the developer to make the use of configName. What do you think? -
Benjamin Kott commented on patch set 5 01/21/20, 14:53
RichTextElement.php:189Reply UnresolvedCurrently, it's the same behavior as before. I also ran into this while testing but was not 100% sure how to handle it. It was a request that you are able to override plugin configuration with an editor configuration. See https://forge.typo3.org/issues/81263. If we take this into account $configuration[$configName] should always win over $config[$config]. Means, if $configuration[$configName] is NOT EMPTY and is a scalar value, we should not override or try to merge it. Makes that sense? -
Rémy DANIEL commented on patch set 5 01/21/20, 17:01
> Patch Set 5: > > (1 comment) > ... we should not override ... Are you sure you mean the *not* here? I agree that $configuration[$configName] should always win. This will keep the behaviour of the arra_replace_recursive. I would vote to apply the same behaviour if $configuration[$configName] is set and is a scalar. -
Benjamin Kott uploaded patch set 6 02/14/20, 14:01
-
TYPO3com voted on patch set 6 V +1 02/14/20, 14:17 Completed build in 15m 29s on Fri, 14 Feb, 02:17 PM Test Summary: 71244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-78
-
Rémy DANIEL voted on patch set 6 V +1 CR +1 02/17/20, 17:46
-
Georg Ringer voted on patch set 6 V +1 CR +1 02/19/20, 14:12
-
Benjamin Kott uploaded patch set 7 02/19/20, 15:20
-
TYPO3com voted on patch set 7 V +1 02/19/20, 15:38 Completed build in 16m 00s on Wed, 19 Feb, 03:38 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-314
-
Benjamin Kott commented on patch set 7 CR -1 02/19/20, 15:39
still checking that the rebase is coorect -
Benjamin Kott commented on patch set 7 CR 0 02/19/20, 15:46
seems fine, please use patchset 6 for backports -
Rémy DANIEL voted on patch set 7 CR +1 02/19/20, 19:52
-
Markus Klein voted on patch set 7 CR +1 02/21/20, 14:07
-
Susi Moog voted on patch set 7 CR +1 02/28/20, 11:05
-
Benni Mack commented on patch set 7 CR -1 03/03/20, 09:26
RST file needs to go into "8.7.x" folder. RST file has a weird naming with the "BUGFIX" prefix. Should be adapted. -
Georg Ringer uploaded patch set 8 03/06/20, 23:44
-
TYPO3com voted on patch set 8 V +1 03/07/20, 00:00 Completed build in 14m 26s on Sat, 7 Mar, 12:00 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1065
-
Benni Mack voted on patch set 8 CR +1 03/24/20, 19:50
-
Georg Ringer voted on patch set 8 V +1 CR +1 03/25/20, 05:18
-
Susi Moog voted on patch set 8 V +2 CR +2 03/25/20, 05:47
-
Susi Moog merged patch set 9 03/25/20, 05:47