Review main Merged

63004[BUGFIX] Prevent overriding ckeditor config from plugins

Benjamin Kott CR +2 V +2 Normal +65 −7 updated 03/25/20, 05:47

Commit message

Configuration from external plugins is now only set if the plugin actually
provided some. By default, the plugin name is used for any configuration
provided by an external plugin. Since the name of the internal configuration
setting can be chosen by the author of a plugin we now provide a new option
to adjust the name that should be used.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2533

Show 68 earlier messages
  1. Benjamin Kott uploaded patch set 1 01/20/20, 23:04

  2. Benjamin Kott commented on patch set 1 CR -1 01/20/20, 23:10

    needs testing needs important rst / feature rst something blindly written ;)
  3. TYPO3com voted on patch set 1 V +1 01/20/20, 23:13 Completed build in 09m 06s on Mon, 20 Jan, 11:13 PM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40117

  4. Benjamin Kott uploaded patch set 2 01/20/20, 23:17

  5. Benjamin Kott commented on patch set 2 V -1 CR -1 01/20/20, 23:18

    needs testing needs important rst / feature rst something blindly written, found first bug while brushing my teeth
  6. TYPO3com voted on patch set 2 V +1 01/20/20, 23:27 Completed build in 09m 15s on Mon, 20 Jan, 11:27 PM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40118

  7. Benjamin Kott uploaded patch set 3 01/21/20, 11:11

  8. Benjamin Kott uploaded patch set 4 01/21/20, 11:12

  1. Benjamin Kott uploaded patch set 5 01/21/20, 11:13

  2. TYPO3com voted on patch set 3 V +1 01/21/20, 11:24 Completed build in 12m 23s on Tue, 21 Jan, 11:24 AM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40120

  3. TYPO3com voted on patch set 4 V +1 01/21/20, 11:31 Completed build in 17m 22s on Tue, 21 Jan, 11:31 AM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40121

  4. TYPO3com voted on patch set 5 V +1 01/21/20, 11:32 Completed build in 18m 12s on Tue, 21 Jan, 11:32 AM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40122

  5. Rémy DANIEL commented on patch set 5 01/21/20, 14:41

    RichTextElement.php:189

    If $configuration[$configName] exists before, it may not be an array. This triggers a warning. Either: - we allow the override of entire array and scalar - it is not allowed to overwrite an existing configuration and an exception should rise and advices the developer to make the use of configName. What do you think?
  6. Benjamin Kott commented on patch set 5 01/21/20, 14:53

    RichTextElement.php:189 Reply Unresolved

    Currently, it's the same behavior as before. I also ran into this while testing but was not 100% sure how to handle it. It was a request that you are able to override plugin configuration with an editor configuration. See https://forge.typo3.org/issues/81263. If we take this into account $configuration[$configName] should always win over $config[$config]. Means, if $configuration[$configName] is NOT EMPTY and is a scalar value, we should not override or try to merge it. Makes that sense?
  7. Rémy DANIEL commented on patch set 5 01/21/20, 17:01

    > Patch Set 5: > > (1 comment) > ... we should not override ... Are you sure you mean the *not* here? I agree that $configuration[$configName] should always win. This will keep the behaviour of the arra_replace_recursive. I would vote to apply the same behaviour if $configuration[$configName] is set and is a scalar.
  8. Benjamin Kott uploaded patch set 6 02/14/20, 14:01

  9. TYPO3com voted on patch set 6 V +1 02/14/20, 14:17 Completed build in 15m 29s on Fri, 14 Feb, 02:17 PM Test Summary: 71244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-78

  10. Rémy DANIEL voted on patch set 6 V +1 CR +1 02/17/20, 17:46

  11. Georg Ringer voted on patch set 6 V +1 CR +1 02/19/20, 14:12

  12. Benjamin Kott uploaded patch set 7 02/19/20, 15:20

  13. TYPO3com voted on patch set 7 V +1 02/19/20, 15:38 Completed build in 16m 00s on Wed, 19 Feb, 03:38 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-314

  14. Benjamin Kott commented on patch set 7 CR -1 02/19/20, 15:39

    still checking that the rebase is coorect
  15. Benjamin Kott commented on patch set 7 CR 0 02/19/20, 15:46

    seems fine, please use patchset 6 for backports
  16. Rémy DANIEL voted on patch set 7 CR +1 02/19/20, 19:52

  17. Markus Klein voted on patch set 7 CR +1 02/21/20, 14:07

  18. Susi Moog voted on patch set 7 CR +1 02/28/20, 11:05

  19. Benni Mack commented on patch set 7 CR -1 03/03/20, 09:26

    RST file needs to go into "8.7.x" folder. RST file has a weird naming with the "BUGFIX" prefix. Should be adapted.
  20. Georg Ringer uploaded patch set 8 03/06/20, 23:44

  21. TYPO3com voted on patch set 8 V +1 03/07/20, 00:00 Completed build in 14m 26s on Sat, 7 Mar, 12:00 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1065

  22. Benni Mack voted on patch set 8 CR +1 03/24/20, 19:50

  23. Georg Ringer voted on patch set 8 V +1 CR +1 03/25/20, 05:18

  24. Susi Moog voted on patch set 8 V +2 CR +2 03/25/20, 05:47

  25. Susi Moog merged patch set 9 03/25/20, 05:47