Review main Merged

63005[TASK] Extend route enhancer test framework

Oliver Hader CR +2 V +2 Hard +213 −47 updated 01/22/20, 11:47

Commit message

* introduce `routeParameter` variable (default `{value}`)
* introduce ExceptionExpectation applicable in test cases
* adjust TestSet::getSingleApplicable($type) to consider
  ApplicableConjunction as well
* adjust configuration/declaration merges

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 57

  1. Oliver Hader uploaded patch set 1 01/21/20, 08:35

  2. TYPO3com voted on patch set 1 V +1 01/21/20, 08:47 Completed build in 12m 10s on Tue, 21 Jan, 08:47 AM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40119

  3. Oliver Hader voted on patch set 1 CR -1 01/22/20, 11:15

  4. Oliver Hader uploaded patch set 2 01/22/20, 11:19

  5. TYPO3com voted on patch set 2 V +1 01/22/20, 11:30 Completed build in 10m 39s on Wed, 22 Jan, 11:30 AM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40130

  6. Oliver Hader voted on patch set 2 V +2 CR +2 01/22/20, 11:47

  7. Oliver Hader merged patch set 3 01/22/20, 11:47