Review 9.5 Merged

63006[TASK] Extend route enhancer test framework

Oliver Hader CR +2 V +2 Hard +213 −47 updated 01/22/20, 11:48

Commit message

* introduce `routeParameter` variable (default `{value}`)
* introduce ExceptionExpectation applicable in test cases
* adjust TestSet::getSingleApplicable($type) to consider
  ApplicableConjunction as well
* adjust configuration/declaration merges

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 46

  1. Oliver Hader uploaded patch set 1 01/21/20, 08:41

  2. TYPO3com voted on patch set 1 V +1 01/21/20, 08:53 Completed build in 11m 32s on Tue, 21 Jan, 08:53 AM Test Summary: 73979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1897

  3. Oliver Hader uploaded patch set 2 01/22/20, 11:19

  4. TYPO3com voted on patch set 2 V +1 01/22/20, 11:33 Completed build in 13m 35s on Wed, 22 Jan, 11:33 AM Test Summary: 73979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1900

  5. Oliver Hader voted on patch set 2 V +2 CR +2 01/22/20, 11:47

  6. Oliver Hader merged patch set 3 01/22/20, 11:48