Review main Merged

63008[FEATURE] Introduce modal actions

Andreas Kienast CR +2 V +2 Normal +77 −20 updated 01/25/20, 11:26

Commit message

Action buttons in modals created by the `TYPO3/CMS/Backend/Modal`
module may now make use of `ImmediateAction` and `DeferredAction`.

As an alternative to the existing `trigger` option, the new option
`action` may be used with an instance of the previously mentioned
modules.

A similar feature has been introduced with #89061 for notifications.

This patch also implements the feature in the recycler module.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 711

  1. Andreas Kienast uploaded patch set 1 01/21/20, 22:32

  2. TYPO3com voted on patch set 1 V -1 01/21/20, 22:44 Completed build in 11m 14s on Tue, 21 Jan, 10:44 PM Test Summary: 70129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40124

  3. TYPO3com voted on patch set 1 V +1 01/21/20, 22:47 Completed build in 25m 31s on Tue, 21 Jan, 10:47 PM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40124

  4. Susi Moog commented on patch set 1 01/22/20, 16:44

    Recycler.ts:512 Unresolved

    remove me.
  5. Andreas Kienast uploaded patch set 2 01/22/20, 16:46

  6. TYPO3com voted on patch set 2 V +1 01/22/20, 16:55 Completed build in 09m 20s on Wed, 22 Jan, 04:55 PM Test Summary: 70569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40150

  7. Andreas Kienast uploaded patch set 3 01/24/20, 18:34

  8. TYPO3com voted on patch set 3 V +1 01/24/20, 18:43 Completed build in 09m 07s on Fri, 24 Jan, 06:43 PM Test Summary: 70581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40201

  9. Susi Moog voted on patch set 3 V +1 CR +1 01/25/20, 11:14

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 01/25/20, 11:26

  11. Daniel Goerz merged patch set 4 01/25/20, 11:26