Review main Abandoned

63018[WIP][FEATURE] no_index and no_follow on translated pages

Riny van Tiggelen CR 0 V 0 Easy +3 −3 updated 04/23/21, 08:08

Commit message

The no_index and no_follow fields are now available to set
on translated pages.
The sitemap XML excludes translated pages with no_index=1.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 68

  1. Riny van Tiggelen uploaded patch set 1 01/23/20, 17:22

  2. TYPO3com voted on patch set 1 V -1 01/23/20, 17:22 Completed build in 07s on Thu, 23 Jan, 05:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40177

  3. Daniel Goerz uploaded patch set 2 01/25/20, 08:48

  4. Daniel Goerz commented on patch set 2 CR -1 01/25/20, 08:51

    Resolved conflicts. Not sure if I like this change though, seems more like something you want to override in your project rather than changing the default. Because with this change you can exclude a translated page from a sitemap while the language parent is not excluded but can't do it the other way around. I think the default, keeping the field in sync over languages, is fine and should not be changed.
  5. TYPO3com voted on patch set 2 V +1 01/25/20, 08:58 Completed build in 09m 47s on Sat, 25 Jan, 08:58 AM Test Summary: 70581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40204

  6. Benni Mack commented on patch set 2 03/20/20, 11:17

    I don't think we should go in this direction. What would be the reason for having a translation with no_index but the default language having it enabled? In addition, the correct way would be "allowLanguageSynchronization" instead of just removing the l10n_mode=exclude. This is not a feature but a bugfix.
  7. Richard Haeser commented on patch set 2 04/23/21, 07:29

    @riny, what is your opinion on this now? I agree with Benni that is is a bit strange to have a difference in 1-on-1 translations.
  8. Riny van Tiggelen abandoned the change 04/23/21, 08:08

    requested feature/bugfix will not be implemented