Review main Merged

63019[TASK] Improve consecutive build performance

Andreas Kienast CR +2 V +2 Easy +26 −10 updated 01/24/20, 10:23

Commit message

To improve the consecutive build experience, several caches now kick in
to only lint and compile files that are necessary.

Following changes are done in this patch:

- added cache for eslint
- build TypeScript incremental
- don't mangle TypeScript twice in a full build

To be able to utilize the `--incremental` feature of TypeScript,
generated files are not removed anymore before a build, since TypeScript
needs the previously compiled files for comparision.

The `tsclean` grunt task has been renamed to `clear-build` and is now
executed right before any *full* build.

Side note: on the patch authors machine, the command `grunt scripts`
went from ~30 seconds to ~8 seconds after second invokation.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Andreas Kienast uploaded patch set 1 01/23/20, 17:28

  2. TYPO3com voted on patch set 1 V -1 01/23/20, 17:37 Completed build in 09m 19s on Thu, 23 Jan, 05:37 PM Test Summary: 1 of 71019 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40178

  3. Andreas Kienast uploaded patch set 2 01/24/20, 07:26

  4. Andreas Kienast uploaded patch set 3 01/24/20, 09:10

  5. TYPO3com voted on patch set 2 V -1 01/24/20, 09:10 Completed build in 31m 28s on Fri, 24 Jan, 09:10 AM Test Summary: 70569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40179

  6. TYPO3com voted on patch set 3 V +1 01/24/20, 09:39 Completed build in 12m 09s on Fri, 24 Jan, 09:39 AM Test Summary: 70569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40180

  7. Richard Haeser voted on patch set 3 V +1 CR +1 01/24/20, 10:12

  8. Daniel Goerz voted on patch set 3 V +2 CR +2 01/24/20, 10:23

  9. Daniel Goerz merged patch set 4 01/24/20, 10:23