Review main Merged

63024[BUGFIX] Adjust root line in Condition Matcher

Susi Moog CR +2 V +2 Easy +7 −3 updated 01/24/20, 17:22

Commit message

- in frontend tests: match the root line to the actual TSFE root line
- in backend condition matcher: sort the root line similar to frontend
  (in ts config the root line was already manually sorted, this change
   has no impact on core code)

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Tobi Kretschmann +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 910

  1. Susi Moog uploaded patch set 1 01/24/20, 16:26

  2. Daniel Goerz updated the commit message in patch set 2 01/24/20, 16:31

  3. Susi Moog commented on patch set 2 01/24/20, 16:31

    This change is ready for review.
  4. TYPO3com voted on patch set 2 V +1 01/24/20, 16:41 Completed build in 09m 41s on Fri, 24 Jan, 04:41 PM Test Summary: 70572 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40194

  5. Tobi Kretschmann voted on patch set 2 CR +1 01/24/20, 16:45

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 01/24/20, 16:45

  7. Tobi Kretschmann voted on patch set 2 V +1 01/24/20, 16:45

  8. Daniel Goerz voted on patch set 2 V +2 CR +2 01/24/20, 16:46

  9. Daniel Goerz merged patch set 3 01/24/20, 16:46

  10. Daniel Goerz commented on patch set 3 01/24/20, 17:22

    We decided against a backport as the test file does not exist and the ConditionMatcher is initialized differently. Also getPagesTSConfig does not apply a ksort to the rootline in 9.5.