Review main Abandoned

63032[TASK] phpstan level 0 compatibility

Alexander Schnitzler CR 0 V 0 Normal +57 −27 updated 02/27/20, 21:05

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 20

Review log 1821

  1. Alexander Schnitzler uploaded patch set 1 01/25/20, 13:30

  2. TYPO3com voted on patch set 1 V +1 01/25/20, 13:44 Completed build in 13m 09s on Sat, 25 Jan, 01:44 PM Test Summary: 70582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40222

  3. Alexander Schnitzler wrote 01/25/20, 13:44

    Topic set to phpstan
  4. Alexander Schnitzler commented on patch set 1 01/25/20, 13:47

    This patch fixes all the issues that phpstan complains about at level 0. Question is: Do we want to split this patch into smaller chunks as some changes might be bugfixes that are worthy to be backported or do we prepare this one to be merged as is (with a proper title and description).
  5. Alexander Schnitzler commented on patch set 1 01/25/20, 13:49

    Unresolved

    Yes, no id yet. If you read this, you probably just started reviewing this patch. Please read my first remark first. Unfortunately Gerrit knows how to hide comments very well...
  6. Susi Moog commented on patch set 1 01/25/20, 14:01

    > Patch Set 1: > > This patch fixes all the issues that phpstan complains about at level 0. > Question is: Do we want to split this patch into smaller chunks as some changes might be bugfixes that are worthy to be backported or do we prepare this one to be merged as is (with a proper title and description). As the last set of automated code clean ups introduced an annoying regression, I'd rather be more careful this time around and would prefer splitting this patch up into logical groups that can be tested separately.
  7. Alexander Schnitzler commented on patch set 1 01/25/20, 14:26

    > Patch Set 1: > > > Patch Set 1: > > > > This patch fixes all the issues that phpstan complains about at level 0. > > Question is: Do we want to split this patch into smaller chunks as some changes might be bugfixes that are worthy to be backported or do we prepare this one to be merged as is (with a proper title and description). > > As the last set of automated code clean ups introduced an annoying regression, I'd rather be more careful this time around and would prefer splitting this patch up into logical groups that can be tested separately. Well, the changes in this patch are all hand-done. No automated clean up. But I get your point.
  8. Alexander Schnitzler commented on patch set 1 01/25/20, 14:30

    LinkValidatorReport.php:176 Unresolved

    Hi Sybille, you are on this patch as you are the author of this patch https://github.com/TYPO3/TYPO3.CMS/commit/bde5e8f5bbaa9118e06c0c6411143bea82c5cada This patch lacks this property. This is not to blame you. I would just like to ask you to create a follow-up patch for this. Thank you.
  9. Alexander Schnitzler commented on patch set 1 01/25/20, 14:33

    DatabaseCheck.php:112

    Hi Manuel, you are a reviewer here as you are the author of this patch https://github.com/TYPO3/TYPO3.CMS/commit/ad43bc30d443eaed4f3aa8790606ca5ac471ffad This patch introduced a wrong property type hint. This is not to blame you. I would just like to ask you to create a follow-up patch for this. Thank you.
  10. Alexander Schnitzler commented on patch set 1 01/25/20, 14:36

    NetworkException.php:40 Unresolved

    Hi Benjamin, you are a reviewer here as you are the author of this patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/61567 This patch missed adding a return here. This is not to blame you. I would just like to ask you to create a follow-up patch for this as you can surely tell if this needs a backport to older versions of TYPO3 as well. Thank you.

    RequestException.php:40 Unresolved

    Hi Benjamin, you are a reviewer here as you are the author of this patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/61567 This patch missed adding a return here. This is not to blame you. I would just like to ask you to create a follow-up patch for this as you can surely tell if this needs a backport to older versions of TYPO3 as well. Thank you.
  11. Alexander Schnitzler commented on patch set 1 01/25/20, 14:40

    AspectFactory.php:21 Unresolved

    Hi Christian, you are a reviewer here as you are the author of this patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893 That patch removed a needed use statement. This is not to blame you. I would just like to ask you to create a follow-up patch for this. Thank you.
  12. Alexander Schnitzler commented on patch set 1 01/25/20, 14:46

    Hi Ralf, you are a reviewer on this patch as phpstan identified a couple of issues in the form extension. I'd like you to review those changes and at best create follow-up patches. Especially the needed changes in AbstractRenderable are hard for me to do right because I don't know the original intentions. If you have questions, don't hesitate to get in contact with me. Thanks.
  13. Alexander Schnitzler commented on patch set 1 01/25/20, 14:51

    PageLayoutController.php:1029 Unresolved

    This change is nonsense.

    TypeConverterException.php:22 Unresolved

    Short explanation regarding this change. phpstan explains about a parent class calling new static() without either making the constructor or the class final. This is an edge case but a quite valid one. A sub class can potentially overwrite the constructor, changing the method signature and let a new static() call fail. For further explanations, don't hesitate to ping me.
  14. Alexander Schnitzler uploaded patch set 2 01/25/20, 17:03

  15. TYPO3com voted on patch set 2 V -1 01/25/20, 17:13 Completed build in 10m 19s on Sat, 25 Jan, 05:13 PM Test Summary: 70573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40228

  16. TYPO3com voted on patch set 2 V +1 01/25/20, 17:25 Completed build in 32m 50s on Sat, 25 Jan, 05:25 PM Test Summary: 70582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40228

  17. Oliver Klee commented on patch set 2 01/25/20, 19:25

    The ticket ID is still missing.
  18. Alexander Schnitzler commented on patch set 2 01/26/20, 17:05

    Reply

    This ticket is split into smaller chunks, therefore a ticket id is not necessary here. Will be abandoned eventually.
  19. Manuel Selbach commented on patch set 2 01/27/20, 21:43

    > Patch Set 1: > > (1 comment)

    DatabaseCheck.php:112 Reply

  20. Alexander Schnitzler commented on patch set 2 01/28/20, 08:30

    DatabaseCheck.php:112 Reply

    Thanks a bunch!
  21. Daniel Goerz abandoned the change 02/27/20, 21:05