Review main Abandoned

63034[BUGFIX] Don’t override the default value

Michael Binder CR 0 V 0 Easy +1 −1 updated 03/24/20, 12:07

Commit message

The Link Browser used the last given titleText instead the choosen default
value. Deleting this part fixed the problem.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Michael Binder uploaded patch set 1 01/25/20, 15:38

  2. TYPO3com voted on patch set 1 V +1 01/25/20, 15:48 Completed build in 09m 15s on Sat, 25 Jan, 03:48 PM Test Summary: 70582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40225

  3. Christiane Helmchen commented on patch set 1 02/03/20, 19:06

    BrowseLinksController.php:217 Unresolved

    We tried the changes in TYPO3 10 and got the result you wanted. One question though: In your example from the bug you set titleText twice for internal links (once for the _blank and once for the normal link). But TYPO3 only ever loads the default titleText, e.g. the internanl-link one from your example. Changing the link type in the Backend doesn't change the title. So why set two defaults in the first place?
  4. Anja Leichsenring commented on patch set 1 02/03/20, 20:00

    the commit message needs a little adaption: the default value of what? Please consider only the headline in a bunch of other commit headlines, e.g. the output of git log. The headline needs to clearly state what the change is about, and TYPO3 has no shortage on default values. Thank you for your consideration.
  5. Daniel Goerz abandoned the change 03/24/20, 12:07