Review main Merged

63035[FEATURE] Add new TypoScript condition `workspace`

Elias Häußler CR +2 V +2 Hard +250 −47 updated 01/26/20, 12:51

Commit message

A new TypoScript condition `workspace` has been added which allows
checking of several workspace parameters against a given expression.
Currently, only workspace id and state can be used within conditions.

Example:

  [workspace.workspaceId === 0]
    # This matches if the current workspace id equals 0
  [end]

  [workspace.isLive]
    # This can be used to check if the current workspace is live
  [end]

  [workspace.isOffline]
    # This can be used to check if the current workspace is offline
  [end]

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 68

  1. Elias Häußler uploaded patch set 1 01/25/20, 16:23

  2. TYPO3com voted on patch set 1 V -1 01/25/20, 16:32 Completed build in 09m 17s on Sat, 25 Jan, 04:32 PM Test Summary: 6 of 71050 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40226

  3. Elias Häußler uploaded patch set 2 01/25/20, 17:24

  4. TYPO3com voted on patch set 2 V +1 01/25/20, 17:36 Completed build in 11m 06s on Sat, 25 Jan, 05:36 PM Test Summary: 70600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40232

  5. Susi Moog voted on patch set 2 CR +1 01/26/20, 08:44

  6. Susi Moog voted on patch set 2 V +1 01/26/20, 09:24

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 01/26/20, 12:51

  8. Daniel Goerz merged patch set 3 01/26/20, 12:51