Review main Abandoned

63037[TASK] Avoid signalSlot property in ExtensionManagementService class

Alexander Schnitzler CR 0 V 0 Easy +1 −5 updated 02/15/20, 12:21

Commit message

Method ExtensionManagementService::getSignalSlotDispatcher() did
create an instance of the signal slot dispatcher and stored it
in a property which wasn't used anywhere else. Therefore, said
method now directly returns the created signal slot dispatcher
instance.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 79

  1. Alexander Schnitzler uploaded patch set 1 01/25/20, 17:10

  2. TYPO3com voted on patch set 1 V -1 01/25/20, 17:21 Completed build in 10m 42s on Sat, 25 Jan, 05:21 PM Test Summary: 2 of 70728 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40229

  3. TYPO3com voted on patch set 1 V +1 01/25/20, 17:28 Completed build in 28m 00s on Sat, 25 Jan, 05:28 PM Test Summary: 70582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40229

  4. Alexander Schnitzler wrote 01/25/20, 17:33

    Topic set to phpstan
  5. Susi Moog commented on patch set 1 CR -1 01/26/20, 09:30

    ExtensionManagementService.php:448

    this was probably done as a way to cache the instance. two things on that here: - the method is only used once currently, so we should remove it and directly instantiate it - to solve it fully: the signals in the extension manager should be migrated to PSR-14 events which would make the change obsolete (see https://review.typo3.org/c/Packages/TYPO3.CMS/+/62528 for an example)
  6. Alexander Schnitzler commented on patch set 1 01/26/20, 10:23

    ExtensionManagementService.php:448 Reply Unresolved

    Caching the instance doesn't make sense. It's a singleton and therefore already "cached" in the container. I agree that moving towards events is the best solution to the overall problem. phpstan however is only interested in either declaring the property or avoiding it.
  7. Oliver Klee voted on patch set 1 CR +1 01/26/20, 12:22

  8. Benni Mack commented on patch set 1 02/14/20, 19:48

    This code is now gone. No fix needed. Alex, can we abandon the change and close the ticket?
  9. Alexander Schnitzler abandoned the change 02/15/20, 12:21

    Solved with another patch