63038[TASK] Remove superfluous method renderRequestHashField
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Daniel Goerz +1
- Oliver Klee +1
-
Verified V +2 Done
- Susi Moog +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1013
-
Alexander Schnitzler uploaded patch set 1 01/25/20, 17:13
-
TYPO3com voted on patch set 1 V -1 01/25/20, 17:27 Completed build in 13m 55s on Sat, 25 Jan, 05:27 PM Test Summary: 70582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40230
-
TYPO3com voted on patch set 1 V +1 01/25/20, 17:31 Completed build in 31m 52s on Sat, 25 Jan, 05:31 PM Test Summary: 70582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40230
-
Alexander Schnitzler wrote 01/25/20, 17:33
Topic set to phpstan -
Oliver Klee voted on patch set 1 CR +1 01/25/20, 19:24
-
Susi Moog voted on patch set 1 V +1 CR +1 01/26/20, 07:44
-
Susi Moog commented on patch set 1 CR -1 01/26/20, 08:27
please remove the mocked methods from the tests, too. -
Daniel Goerz uploaded patch set 2 01/26/20, 12:01
-
TYPO3com voted on patch set 2 V +1 01/26/20, 12:11 Completed build in 09m 48s on Sun, 26 Jan, 12:11 PM Test Summary: 70581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40238
-
Oliver Klee voted on patch set 2 CR +1 01/26/20, 12:21
-
Daniel Goerz voted on patch set 2 V +1 CR +1 01/26/20, 12:23
-
Susi Moog voted on patch set 2 V +2 CR +2 01/26/20, 12:23
-
Susi Moog merged patch set 3 01/26/20, 12:23