Review main Merged

63040[BUGFIX] Not include defer files to concatenateJs

Guido Schmechel CR +2 V +2 Easy +22 −1 updated 03/20/20, 06:42

Commit message

Deferred files should not be concatenated. They are now
output as a single script.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Ghanshyam Bhava +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1112

  1. Guido Schmechel uploaded patch set 1 01/26/20, 13:17

  2. TYPO3com voted on patch set 1 V +1 01/26/20, 13:26 Completed build in 08m 49s on Sun, 26 Jan, 01:26 PM Test Summary: 70606 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40239

  3. Ghanshyam Bhava voted on patch set 1 CR +1 01/27/20, 07:42

  4. Oliver Klee voted on patch set 1 CR +1 01/27/20, 10:59

  5. Oli Bartsch voted on patch set 1 CR +1 01/31/20, 21:00

  6. Benni Mack commented on patch set 1 02/27/20, 11:30

    and "async" as well?
  7. Guido Schmechel voted on patch set 1 CR -1 02/27/20, 11:38

  8. Guido Schmechel commented on patch set 1 02/27/20, 19:48

    Hi Benni, if I add the query for async we have a "breaking" change. Context: If we concatenate two files and set both to "async", we had one file with the attribute async in the frontend. If I change the condition, we have two files with the attribute "async".
  9. Benni Mack commented on patch set 1 V +1 CR +1 03/19/20, 15:09

    Guido - let's keep it as is for now!
  10. Guido Schmechel voted on patch set 1 CR 0 03/19/20, 15:12

  11. Susi Moog voted on patch set 1 V +2 CR +2 03/20/20, 06:42

  12. Susi Moog merged patch set 2 03/20/20, 06:42