63043[!!!][FEATURE] Allow use of Fluid 3.x and preserve 2.x compat
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 33
- typo3/sysext/adminpanel/composer.json+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+1 −1
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/Main.html+1 −1
- typo3/sysext/core/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+2 −21
- typo3/sysext/core/Documentation/Changelog/master/Breaking-90210-MethodGetNameOnFormViewHelpersRenamedToGetFieldName.rst new+41 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-90210-SupportFluid2xAnd3x.rst new+40 −0
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+50 −12
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php+2 −1
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php+38 −4
- typo3/sysext/fluid/Classes/View/StandaloneView.php+3 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Widget/Controller/PaginateController.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/AbstractBackendViewHelper.php+6 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptionViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+15 −15
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormViewHelper.php+5 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php+1 −1
Show 13 more files
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+5 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/Controller/PaginateController.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+17 −17
- typo3/sysext/fluid/Tests/Unit/Core/Rendering/RenderingContextTest.php+1 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.php+18 −18
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.php+2 −2
- typo3/sysext/fluid/composer.json+1 −1
- typo3/sysext/redirects/composer.json+1 −1
Review log 2546
Show 1121 earlier messages
-
Claus Due uploaded patch set 1 01/26/20, 21:27
-
TYPO3com voted on patch set 1 V -1 01/26/20, 21:27 Completed build in 18s on Sun, 26 Jan, 09:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40244
-
Claus Due uploaded patch set 2 01/26/20, 21:30
-
TYPO3com voted on patch set 2 V -1 01/26/20, 21:30 Completed build in 15s on Sun, 26 Jan, 09:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40245
-
Claus Due uploaded patch set 3 01/27/20, 08:58
-
TYPO3com voted on patch set 3 V -1 01/27/20, 08:58 Completed build in 16s on Mon, 27 Jan, 08:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40247
-
Claus Due uploaded patch set 4 01/27/20, 09:11
-
TYPO3com voted on patch set 4 V -1 01/27/20, 09:12 Completed build in 15s on Mon, 27 Jan, 09:12 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40249
-
Claus Due uploaded patch set 5 01/27/20, 09:28
-
TYPO3com voted on patch set 5 V -1 01/27/20, 09:28 Completed build in 15s on Mon, 27 Jan, 09:28 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40250
-
Claus Due uploaded patch set 6 01/27/20, 10:03
-
TYPO3com voted on patch set 6 V -1 01/27/20, 10:04 Completed build in 16s on Mon, 27 Jan, 10:04 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40251
-
Claus Due uploaded patch set 7 01/27/20, 10:19
-
TYPO3com voted on patch set 7 V -1 01/27/20, 10:19 Completed build in 15s on Mon, 27 Jan, 10:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40253
-
Claus Due uploaded patch set 8 01/27/20, 10:21
-
TYPO3com voted on patch set 8 V -1 01/27/20, 10:21 Completed build in 16s on Mon, 27 Jan, 10:21 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40254
-
Claus Due uploaded patch set 9 01/27/20, 10:23
-
TYPO3com voted on patch set 9 V -1 01/27/20, 10:23 Completed build in 15s on Mon, 27 Jan, 10:23 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40255
-
Claus Due uploaded patch set 10 01/27/20, 10:42
-
TYPO3com voted on patch set 10 V -1 01/27/20, 10:42 Completed build in 15s on Mon, 27 Jan, 10:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40256
-
Claus Due uploaded patch set 11 01/27/20, 10:44
-
TYPO3com voted on patch set 11 V -1 01/27/20, 10:44 Completed build in 14s on Mon, 27 Jan, 10:44 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40257
-
Claus Due uploaded patch set 12 01/27/20, 11:01
-
TYPO3com voted on patch set 12 V -1 01/27/20, 11:01 Completed build in 14s on Mon, 27 Jan, 11:01 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40261
-
Benni Mack commented on patch set 12 01/27/20, 11:14
Hey Claus. This is impressive! How about we'll do it like this: - Let's get the changes regarding getName() -> getFieldName() and the RuntimeException removals in a separate pre-patch into Core, making this actual change super trivial. What do you think? -
Claus Due uploaded patch set 13 01/27/20, 11:31
-
TYPO3com voted on patch set 13 V -1 01/27/20, 11:32 Completed build in 14s on Mon, 27 Jan, 11:32 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40263
-
Claus Due uploaded patch set 14 01/27/20, 11:35
-
TYPO3com voted on patch set 14 V -1 01/27/20, 11:35 Completed build in 15s on Mon, 27 Jan, 11:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40264
-
Claus Due uploaded patch set 15 01/27/20, 11:36
-
TYPO3com voted on patch set 15 V -1 01/27/20, 11:37 Completed build in 14s on Mon, 27 Jan, 11:37 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40265
-
Claus Due uploaded patch set 16 01/27/20, 11:41
-
Claus Due wrote 01/27/20, 11:42
Description set to "Functionally complete and reduced to minimum size" -
TYPO3com voted on patch set 16 V -1 01/27/20, 11:43 Completed build in 23s on Mon, 27 Jan, 11:43 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40267
-
Claus Due uploaded patch set 17 01/27/20, 11:47
-
TYPO3com voted on patch set 17 V -1 01/27/20, 11:55 Completed build in 06m 59s on Mon, 27 Jan, 11:55 AM Test Summary: 3 of 3028 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40268
-
Claus Due uploaded patch set 18 01/27/20, 11:56
-
TYPO3com voted on patch set 18 V -1 01/27/20, 12:06 Completed build in 09m 34s on Mon, 27 Jan, 12:06 PM Test Summary: 97 of 71050 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40269
-
Claus Due uploaded patch set 19 01/27/20, 13:30
-
Claus Due uploaded patch set 20 01/27/20, 13:43
-
TYPO3com voted on patch set 19 V -1 01/27/20, 13:43 Completed build in 12m 59s on Mon, 27 Jan, 01:43 PM Test Summary: 36 of 71050 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40271
-
TYPO3com voted on patch set 20 V -1 01/27/20, 13:43 Completed build in 13s on Mon, 27 Jan, 01:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40272
-
Claus Due uploaded patch set 21 01/27/20, 13:48
-
TYPO3com voted on patch set 21 V -1 01/27/20, 14:03 Completed build in 13m 37s on Mon, 27 Jan, 02:03 PM Test Summary: 36 of 71050 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40274
-
Claus Due commented on patch set 21 01/31/20, 14:51
> Patch Set 12: > > Hey Claus. This is impressive! > > How about we'll do it like this: > - Let's get the changes regarding getName() -> getFieldName() and the RuntimeException removals in a separate pre-patch into Core, making this actual change super trivial. What do you think? Completely agree! * Change access to ViewHelperVariableContainer: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63101 * Remove throwing of RuntimeException: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63102 * Rename getName to getFieldName: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63100 -
Claus Due abandoned the change 02/02/20, 11:15
Replaced with individual merge requests for the four different things this original merge request aimed to achieve. Some refactoring has been done in Fluid 3.0 to avoid the need for adding breaking changes in TYPO3.