Review main Abandoned Breaking

63043[!!!][FEATURE] Allow use of Fluid 3.x and preserve 2.x compat

Claus Due CR 0 V 0 Hard +265 −134 updated 02/02/20, 11:15

Commit message

This patch allows the use of Fluid 3.x with TYPO3 while
preserving the compatibility with Fluid 2.x. This allows
users to select which major version of Fluid they wish
to use for a given project.

Marked as breaking change since method "getName"
on form field ViewHelpers had to be renamed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 33

Show 13 more files

Review log 2546

Show 1121 earlier messages
  1. Claus Due uploaded patch set 1 01/26/20, 21:27

  2. TYPO3com voted on patch set 1 V -1 01/26/20, 21:27 Completed build in 18s on Sun, 26 Jan, 09:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40244

  3. Claus Due uploaded patch set 2 01/26/20, 21:30

  4. TYPO3com voted on patch set 2 V -1 01/26/20, 21:30 Completed build in 15s on Sun, 26 Jan, 09:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40245

  5. Claus Due uploaded patch set 3 01/27/20, 08:58

  6. TYPO3com voted on patch set 3 V -1 01/27/20, 08:58 Completed build in 16s on Mon, 27 Jan, 08:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40247

  7. Claus Due uploaded patch set 4 01/27/20, 09:11

  8. TYPO3com voted on patch set 4 V -1 01/27/20, 09:12 Completed build in 15s on Mon, 27 Jan, 09:12 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40249

  9. Claus Due uploaded patch set 5 01/27/20, 09:28

  10. TYPO3com voted on patch set 5 V -1 01/27/20, 09:28 Completed build in 15s on Mon, 27 Jan, 09:28 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40250

  11. Claus Due uploaded patch set 6 01/27/20, 10:03

  12. TYPO3com voted on patch set 6 V -1 01/27/20, 10:04 Completed build in 16s on Mon, 27 Jan, 10:04 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40251

  13. Claus Due uploaded patch set 7 01/27/20, 10:19

  14. TYPO3com voted on patch set 7 V -1 01/27/20, 10:19 Completed build in 15s on Mon, 27 Jan, 10:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40253

  15. Claus Due uploaded patch set 8 01/27/20, 10:21

  16. TYPO3com voted on patch set 8 V -1 01/27/20, 10:21 Completed build in 16s on Mon, 27 Jan, 10:21 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40254

  17. Claus Due uploaded patch set 9 01/27/20, 10:23

  18. TYPO3com voted on patch set 9 V -1 01/27/20, 10:23 Completed build in 15s on Mon, 27 Jan, 10:23 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40255

  19. Claus Due uploaded patch set 10 01/27/20, 10:42

  20. TYPO3com voted on patch set 10 V -1 01/27/20, 10:42 Completed build in 15s on Mon, 27 Jan, 10:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40256

  21. Claus Due uploaded patch set 11 01/27/20, 10:44

  1. TYPO3com voted on patch set 11 V -1 01/27/20, 10:44 Completed build in 14s on Mon, 27 Jan, 10:44 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40257

  2. Claus Due uploaded patch set 12 01/27/20, 11:01

  3. TYPO3com voted on patch set 12 V -1 01/27/20, 11:01 Completed build in 14s on Mon, 27 Jan, 11:01 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40261

  4. Benni Mack commented on patch set 12 01/27/20, 11:14

    Hey Claus. This is impressive! How about we'll do it like this: - Let's get the changes regarding getName() -> getFieldName() and the RuntimeException removals in a separate pre-patch into Core, making this actual change super trivial. What do you think?
  5. Claus Due uploaded patch set 13 01/27/20, 11:31

  6. TYPO3com voted on patch set 13 V -1 01/27/20, 11:32 Completed build in 14s on Mon, 27 Jan, 11:32 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40263

  7. Claus Due uploaded patch set 14 01/27/20, 11:35

  8. TYPO3com voted on patch set 14 V -1 01/27/20, 11:35 Completed build in 15s on Mon, 27 Jan, 11:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40264

  9. Claus Due uploaded patch set 15 01/27/20, 11:36

  10. TYPO3com voted on patch set 15 V -1 01/27/20, 11:37 Completed build in 14s on Mon, 27 Jan, 11:37 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40265

  11. Claus Due uploaded patch set 16 01/27/20, 11:41

  12. Claus Due wrote 01/27/20, 11:42

    Description set to "Functionally complete and reduced to minimum size"
  13. TYPO3com voted on patch set 16 V -1 01/27/20, 11:43 Completed build in 23s on Mon, 27 Jan, 11:43 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40267

  14. Claus Due uploaded patch set 17 01/27/20, 11:47

  15. TYPO3com voted on patch set 17 V -1 01/27/20, 11:55 Completed build in 06m 59s on Mon, 27 Jan, 11:55 AM Test Summary: 3 of 3028 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40268

  16. Claus Due uploaded patch set 18 01/27/20, 11:56

  17. TYPO3com voted on patch set 18 V -1 01/27/20, 12:06 Completed build in 09m 34s on Mon, 27 Jan, 12:06 PM Test Summary: 97 of 71050 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40269

  18. Claus Due uploaded patch set 19 01/27/20, 13:30

  19. Claus Due uploaded patch set 20 01/27/20, 13:43

  20. TYPO3com voted on patch set 19 V -1 01/27/20, 13:43 Completed build in 12m 59s on Mon, 27 Jan, 01:43 PM Test Summary: 36 of 71050 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40271

  21. TYPO3com voted on patch set 20 V -1 01/27/20, 13:43 Completed build in 13s on Mon, 27 Jan, 01:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40272

  22. Claus Due uploaded patch set 21 01/27/20, 13:48

  23. TYPO3com voted on patch set 21 V -1 01/27/20, 14:03 Completed build in 13m 37s on Mon, 27 Jan, 02:03 PM Test Summary: 36 of 71050 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40274

  24. Claus Due commented on patch set 21 01/31/20, 14:51

    > Patch Set 12: > > Hey Claus. This is impressive! > > How about we'll do it like this: > - Let's get the changes regarding getName() -> getFieldName() and the RuntimeException removals in a separate pre-patch into Core, making this actual change super trivial. What do you think? Completely agree! * Change access to ViewHelperVariableContainer: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63101 * Remove throwing of RuntimeException: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63102 * Rename getName to getFieldName: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63100
  25. Claus Due abandoned the change 02/02/20, 11:15

    Replaced with individual merge requests for the four different things this original merge request aimed to achieve. Some refactoring has been done in Fluid 3.0 to avoid the need for adding breaking changes in TYPO3.