Review main Merged

63044[BUGFIX] Avoid PHP fatal error if colPos is not string

Claus Due CR +2 V +2 Easy +1 −1 updated 01/27/20, 07:21

Commit message

The newly added class \TYPO3\CMS\Backend\View\PageLayoutViewDrawEmptyColposContent
incorrectly assumes that colPos values are always strings
when they may very well be integers. This patch casts
the possibly-integer value to string before use of trim().

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Claus Due uploaded patch set 1 01/26/20, 22:51

  2. TYPO3com voted on patch set 1 V +1 01/26/20, 23:02 Completed build in 10m 19s on Sun, 26 Jan, 11:02 PM Test Summary: 70600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40246

  3. Oliver Klee commented on patch set 1 01/26/20, 23:53

    For the sake of correctness, should we change this in 9.5 as well?
  4. Georg Ringer voted on patch set 1 V +1 CR +1 01/27/20, 05:50

  5. Andreas Kienast commented on patch set 1 V +2 CR +2 01/27/20, 07:20

    Reply Unresolved

    No, since event dispatching doesn't exist in 9.5.
  6. Andreas Kienast merged patch set 2 01/27/20, 07:21