Review main Merged

63045[FEATURE] Migrate Extension-related signals to PSR-14 events

Benni Mack CR +2 V +2 Expert +894 −222 updated 01/31/20, 12:22

Commit message

This change migrates all left-over signals in TYPO3 Core to PSR-14-compatible
events.

Package manager - related events have been moved to EXT:core to decouple
ExtensionManager functionality from PackageManager.

The following signals have been moved to events:
PackageManagement::packagesMayHaveChanged => PackagesMayHaveChangedEvent
InstallUtility::afterExtensionInstall => AfterPackageActivationEvent
InstallUtility::afterExtensionUninstall => AfterPackageDeactivationEvent
InstallUtility::afterExtensionT3DImport => AfterExtensionStaticDatabaseContentHasBeenImportedEvent
InstallUtility::afterExtensionStaticSqlImport => AfterExtensionStaticDatabaseContentHasBeenImportedEvent
InstallUtility::afterExtensionFileImport => AfterExtensionFilesHaveBeenImportedEvent
ExtensionManagementService::willInstallExtensions => BeforePackageActivationEvent
ProcessAvailableActionsViewHelper::processActions => AvailableActionsForExtensionEvent

Next up: Deprecate signal slot dispatcher.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 29

Show 9 more files

Review log 815

  1. Benni Mack uploaded patch set 1 01/27/20, 08:58

  2. TYPO3com voted on patch set 1 V -1 01/27/20, 09:10 Completed build in 11m 53s on Mon, 27 Jan, 09:10 AM Test Summary: 5 of 71053 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40248

  3. Benni Mack uploaded patch set 2 01/29/20, 15:47

  4. TYPO3com voted on patch set 2 V -1 01/29/20, 16:01 Completed build in 14m 02s on Wed, 29 Jan, 04:01 PM Test Summary: 3 of 71281 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40330

  5. Benni Mack uploaded patch set 3 01/29/20, 16:19

  6. TYPO3com voted on patch set 3 V -1 01/29/20, 16:42 Completed build in 14m 41s on Wed, 29 Jan, 04:42 PM Test Summary: 3 of 71293 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40335

  7. TYPO3com commented on patch set 3 01/29/20, 18:53 Completed build in 2h 40m 28s on Wed, 29 Jan, 06:53 PM Test Summary: 3 of 71293 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40335

  8. Benni Mack uploaded patch set 4 01/30/20, 11:32

  9. TYPO3com voted on patch set 4 V -1 01/30/20, 11:43 Completed build in 11m 47s on Thu, 30 Jan, 11:43 AM Test Summary: 70535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40351

  10. TYPO3com voted on patch set 4 V +1 01/30/20, 11:58 Completed build in 38m 21s on Thu, 30 Jan, 11:58 AM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40351

  11. Benni Mack uploaded patch set 5 01/31/20, 10:39

  12. TYPO3com voted on patch set 5 V +1 01/31/20, 10:52 Completed build in 13m 02s on Fri, 31 Jan, 10:52 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40391

  13. Susi Moog voted on patch set 5 V +1 CR +1 01/31/20, 11:46

  14. Andreas Kienast voted on patch set 5 V +2 CR +2 01/31/20, 12:22

  15. Andreas Kienast merged patch set 6 01/31/20, 12:22