Review main Merged

63046[FEATURE] Support bit-wise and in TypoScript checkIf

Daniel Siepmann CR +2 V +2 Normal +79 −0 updated 02/15/20, 07:36

Commit message

Allows direct checks whether an expected bit is part of a bit set, e.g.
in a stored checkbox or radio of a record.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1218

  1. Daniel Siepmann uploaded patch set 1 01/27/20, 11:30

  2. TYPO3com voted on patch set 1 V -1 01/27/20, 11:30 Completed build in 21s on Mon, 27 Jan, 11:30 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40262

  3. Daniel Siepmann uploaded patch set 2 01/27/20, 11:41

  4. TYPO3com voted on patch set 2 V +1 01/27/20, 11:51 Completed build in 09m 28s on Mon, 27 Jan, 11:51 AM Test Summary: 70636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40266

  5. Oliver Klee commented on patch set 2 01/27/20, 13:05

    ContentObjectRendererTest.php:5918

    Please let's have type annotations here for the parameters and a return type annotation for the data provider.
  6. Daniel Siepmann uploaded patch set 3 01/27/20, 13:47

  7. Daniel Siepmann commented on patch set 3 01/27/20, 13:49

    ContentObjectRendererTest.php:5918 Reply

    Done
  8. TYPO3com voted on patch set 3 V -1 01/27/20, 13:59 Completed build in 11m 55s on Mon, 27 Jan, 01:59 PM Test Summary: 1 of 71087 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40273

  9. TYPO3com voted on patch set 3 V +1 01/27/20, 14:20 Completed build in 44m 59s on Mon, 27 Jan, 02:20 PM Test Summary: 70636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40273

  10. Daniel Siepmann uploaded patch set 4 01/27/20, 14:44

  11. TYPO3com voted on patch set 4 V +1 01/27/20, 14:53 Completed build in 08m 59s on Mon, 27 Jan, 02:53 PM Test Summary: 70636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40275

  12. Georg Ringer voted on patch set 4 V +1 CR +1 02/14/20, 20:23

  13. Benni Mack updated the commit message in patch set 5 02/14/20, 20:27

  14. Georg Ringer voted on patch set 5 V +1 CR +1 02/14/20, 20:39

  15. TYPO3com voted on patch set 5 V +1 02/14/20, 21:37 Completed build in 1h 09m 28s on Fri, 14 Feb, 09:37 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-91

  16. Stefan Froemken commented on patch set 5 V +1 CR +1 02/14/20, 22:09

    Yeah. Works. Who will update the official documentation after merge?
  17. Benni Mack voted on patch set 5 V +2 CR +2 02/15/20, 07:36

  18. Benni Mack merged patch set 6 02/15/20, 07:36