63053[TASK] Check valid database name specific for DBMS
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/AbstractPlatform.php8+7 −2
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/PostgreSql.php+28 −0
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/Sqlite.php3+30 −0
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck/Platform/SqlSrv.php2+49 −0
Review log 3545
Show 1520 earlier messages
-
Manuel Selbach uploaded patch set 1 01/27/20, 21:56
-
TYPO3com voted on patch set 1 V +1 01/27/20, 22:07 Completed build in 11m 01s on Mon, 27 Jan, 10:07 PM Test Summary: 70600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40288
-
Oliver Klee commented on patch set 1 01/27/20, 23:52
-
Manuel Selbach uploaded patch set 2 02/05/20, 08:55
-
Manuel Selbach uploaded patch set 3 02/11/20, 22:01
-
Manuel Selbach commented on patch set 3 02/11/20, 22:03
This change is ready for review.AbstractPlatform.php:36Reply UnresolvedThanks for the first feedback. I'm still working on this patch, but yes, it should be possible to overwrite the value in the actual classes, see the other patchsets :) -
Oliver Klee commented on patch set 3 02/11/20, 22:15
I've just tested that constants can be overwritten in subclasses. -
Manuel Selbach uploaded patch set 4 02/12/20, 10:40
-
Manuel Selbach commented on patch set 4 02/12/20, 10:41
> Patch Set 3: > > I've just tested that constants can be overwritten in subclasses. Thanks again for checking. I changed it, but scoping is a thing that should be kept in mind ;) If you would use self:: instead of static::, you would get the parent value. -
TYPO3com voted on patch set 4 V -1 02/12/20, 12:58 Completed build in 13m 44s on Wed, 12 Feb, 12:58 PM Test Summary: 71262 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13
-
TYPO3com commented on patch set 4 02/17/20, 20:06 Completed build in 13m 42s on Mon, 17 Feb, 08:06 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-221
-
Manuel Selbach uploaded patch set 5 02/17/20, 20:44
-
TYPO3com voted on patch set 5 V +1 02/17/20, 21:10 Completed build in 18m 42s on Mon, 17 Feb, 09:10 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-224
-
Stefan Froemken commented on patch set 5 CR -1 02/17/20, 22:30
SqlSrv.php:185PostGre? -
Manuel Selbach commented on patch set 5 02/17/20, 22:36
SqlSrv.php:185Reply UnresolvedYes, right, some copy / paste issue. I will adapt the whole message. Thanks for finding that one. -
Manuel Selbach uploaded patch set 6 02/17/20, 22:59
-
TYPO3com voted on patch set 6 V +1 02/17/20, 23:31 Completed build in 24m 34s on Mon, 17 Feb, 11:31 PM Test Summary: 71338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-234
-
Oliver Klee commented on patch set 6 02/17/20, 23:44
AbstractPlatform.php:66UnresolvedIf the const is the maximum length, shouldn't that be <= instead of < for valid lengths? -
Manuel Selbach uploaded patch set 7 02/18/20, 08:03
-
Manuel Selbach commented on patch set 7 02/18/20, 08:05
> Patch Set 6: > > (1 comment) Thanks for the hint, you're right! I adapted it also for the other specific checks
-
TYPO3com voted on patch set 7 V +1 02/18/20, 08:17 Completed build in 13m 19s on Tue, 18 Feb, 08:17 AM Test Summary: 71338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-235
-
Daniel Siepmann commented on patch set 7 V -1 CR -1 02/20/20, 09:35
Sqlite.php:82Results in the following error: > (1/1) TypeError > > Return value of TYPO3\CMS\Install\SystemEnvironment\DatabaseCheck\Platform\Sqlite::isValidDatabaseName() must be of the type bool, int returned as preg_match may return an int and "strict_types" is set. https://www.php.net/manual/en/function.preg-match.php > preg_match() returns 1 if the pattern matches given subject, 0 if it does not, or FALSE if an error occurred. -
Manuel Selbach rebased onto patch set 8 02/20/20, 13:50
-
Manuel Selbach uploaded patch set 9 02/20/20, 13:52
-
Daniel Siepmann commented on patch set 9 V +1 02/20/20, 13:56
Tested with sqlite, not tested with all others. -
Daniel Siepmann commented on patch set 9 02/20/20, 13:57
Sqlite.php:82ReplyDone -
TYPO3com voted on patch set 8 V +1 02/20/20, 14:37 Completed build in 36m 16s on Thu, 20 Feb, 02:37 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-343
-
TYPO3com voted on patch set 9 V +1 02/20/20, 14:47 Completed build in 46m 34s on Thu, 20 Feb, 02:47 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-344
-
Susi Moog voted on patch set 9 CR +1 02/22/20, 17:20
-
Susi Moog commented on patch set 9 V +1 02/22/20, 17:24
tested sqlite and mysql -
Susi Moog rebased onto patch set 10 02/28/20, 06:21
-
Susi Moog commented on patch set 10 02/28/20, 06:21
(rebased to get phpstan results ;)) -
TYPO3com voted on patch set 10 V +1 02/28/20, 06:33 Completed build in 12m 20s on Fri, 28 Feb, 06:33 AM Test Summary: 72003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-761
-
Susi Moog voted on patch set 10 V +1 CR +1 02/28/20, 06:37
-
Markus Klein commented on patch set 10 CR -1 02/28/20, 08:31
AbstractPlatform.php:66AFAIK late static binding for const does not work. -
Susi Moog commented on patch set 10 02/28/20, 08:40
AbstractPlatform.php:66Reply UnresolvedI think they do... https://repl.it/repls/LovableMoralCookie -
Andreas Kienast commented on patch set 10 02/28/20, 08:53
AbstractPlatform.php:77"must be shorter than" should be rephrased, as "equals to" would still be fine. What about "The given database name must not be longer than..."? -
Susi Moog commented on patch set 10 02/28/20, 09:01
AbstractPlatform.php:77Reply Unresolvedgo ahead, sounds good I'd say. -
Andreas Kienast uploaded patch set 11 02/28/20, 09:20
-
TYPO3com voted on patch set 11 V +1 02/28/20, 09:30 Completed build in 10m 36s on Fri, 28 Feb, 09:30 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-777
-
Susi Moog voted on patch set 11 V +1 CR +1 02/28/20, 09:44
-
Benni Mack voted on patch set 11 V +2 CR +2 03/01/20, 19:09
-
Benni Mack merged patch set 12 03/01/20, 19:09
-
Alexander Schnitzler commented on patch set 12 03/01/20, 20:47
AbstractPlatform.php:36UnresolvedThis is a bit of a nitpick but I would suggest not to use class constants like this directly as api but use an interface method instead. This makes the need for this mandatory length more visible and follows a clean oop approach. Constants can still be used but it should be encapsulated in an interface method which ensures type safety as long as we don't have type safe constants in php. -
Markus Klein commented on patch set 12 12/20/21, 21:48
Sqlite.php:82UnresolvedFrankly the Core itself generates invalid names... `$dbFilename = '/cms-' . (new Random())->generateRandomHexString(8) . '.sqlite';` https://forge.typo3.org/issues/96406
AbstractPlatform.php:36