Review 9.5 Merged

63059[TASK] Streamline CacheHashCalculator test case

Oliver Hader CR +2 V +2 Normal +34 −22 updated 01/28/20, 14:19

Commit message

Injects configuration to constructor directly, avoids using
MockBuilder to define internal values (part of configuration).

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 35

  1. Oliver Hader uploaded patch set 1 01/28/20, 14:02

  2. TYPO3com voted on patch set 1 V -1 01/28/20, 14:12 Completed build in 10m 15s on Tue, 28 Jan, 02:12 PM Test Summary: 74209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1924

  3. TYPO3com voted on patch set 1 V +1 01/28/20, 14:16 Completed build in 24m 18s on Tue, 28 Jan, 02:16 PM Test Summary: 74210 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1924

  4. Benni Mack voted on patch set 1 V +2 CR +2 01/28/20, 14:19

  5. Benni Mack merged patch set 2 01/28/20, 14:19