Review main Merged

63061[BUGFIX] Do not use rowCount() in linkvalidator report

Daniel Siepmann CR +2 V +2 Easy +22 −18 updated 01/30/20, 14:14

Commit message

As `rowCount()` is not supported across all DBMS (e.g. sqlite).

The logic is kept, but instead of relying on row count, the list of
items is built first, and checked afterwards.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sybille Peters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sybille Peters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1115

  1. Daniel Siepmann uploaded patch set 1 01/28/20, 14:45

  2. Mathias Brodala commented on patch set 1 01/28/20, 14:46

    LinkValidatorReport.php:533

    Please use !empty($items) instead as usual.
  3. Daniel Siepmann uploaded patch set 2 01/28/20, 14:54

  4. Daniel Siepmann uploaded patch set 3 01/28/20, 14:55

  5. Daniel Siepmann uploaded patch set 4 01/28/20, 14:56

  6. TYPO3com voted on patch set 1 V +1 01/28/20, 14:56 Completed build in 11m 40s on Tue, 28 Jan, 02:56 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40296

  7. Daniel Siepmann commented on patch set 4 01/28/20, 14:57

    Switched to empty() and !empty()

    LinkValidatorReport.php:533 Reply

    Done
  8. TYPO3com voted on patch set 2 V +1 01/28/20, 15:05 Completed build in 11m 03s on Tue, 28 Jan, 03:05 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40297

  9. TYPO3com voted on patch set 3 V +1 01/28/20, 15:10 Completed build in 14m 41s on Tue, 28 Jan, 03:10 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40298

  10. TYPO3com voted on patch set 4 V +1 01/28/20, 15:15 Completed build in 14m 29s on Tue, 28 Jan, 03:15 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40299

  11. Benni Mack voted on patch set 4 CR +1 01/28/20, 17:34

  12. Benni Mack voted on patch set 4 V +1 01/30/20, 12:18

  13. Sybille Peters voted on patch set 4 V +1 CR +1 01/30/20, 14:08

  14. Benni Mack voted on patch set 4 V +2 CR +2 01/30/20, 14:14

  15. Benni Mack merged patch set 5 01/30/20, 14:14