Review main Merged

63062[FEATURE] Introduce CacheHashConfiguration and matching indicators

Oliver Hader CR +2 V +2 Hard +566 −92 updated 01/31/20, 10:04

Commit message

Settings for $GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash'] are modelled
in CacheHashConfiguration which takes care of validating configuration.
It also determines whether corresponding aspects apply to a given URL
parameter.

Besides exact matches (equals) it is possible to apply partial matches at
the beginning of a parameter (startsWith) or inline occurrences (contains).

URL parameter names are prefixed with the following indicators:
+ = (equals): exact match, default behavior if not given
+ ^ (startsWith): matching the beginning of a parameter name
+ ~ (contains): matching any inline occurrence in a parameter name

These indicators can be used for all previously existing sub-properties
'cachedParametersWhiteList', 'excludedParameters', 'excludedParametersIfEmpty'
and 'requireCacheHashPresenceParameters'.

Example:
$GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash'] = [
  'excludedParameters' => [
    'utm_source',
    'utm_medium',
    '^utm_', // making previous two obsolete
  ],
  'excludedParametersIfEmpty' => [
    '^tx_my_plugin[aspects]',
    'tx_my_plugin[filter]',
  ],
];

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 916

  1. Oliver Hader uploaded patch set 1 01/28/20, 17:18

  2. TYPO3com voted on patch set 1 V +1 01/28/20, 17:29 Completed build in 10m 51s on Tue, 28 Jan, 05:29 PM Test Summary: 70833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40301

  3. Oliver Hader uploaded patch set 2 01/29/20, 12:20

  4. TYPO3com voted on patch set 2 V -1 01/29/20, 12:21 Completed build in 20s on Wed, 29 Jan, 12:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40316

  5. Oliver Hader uploaded patch set 3 01/29/20, 12:23

  6. TYPO3com commented on patch set 3 01/29/20, 12:23 Completed build in 22s on Wed, 29 Jan, 12:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40317

  7. Oliver Hader uploaded patch set 4 01/29/20, 17:04

  8. TYPO3com voted on patch set 4 V -1 01/29/20, 17:13 Completed build in 09m 16s on Wed, 29 Jan, 05:13 PM Test Summary: 10040 of 71463 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40336

  9. TYPO3com commented on patch set 4 01/29/20, 18:20 Completed build in 1h 25m 11s on Wed, 29 Jan, 06:20 PM Test Summary: 10040 of 71463 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40336

  10. Oliver Hader commented on patch set 4 01/29/20, 18:38

    ... nice ... dependency injection triggered as side-effect in other test cases... let's make it uglier then... ;)
  11. Oliver Hader uploaded patch set 5 01/29/20, 18:41

  12. TYPO3com voted on patch set 5 V -1 01/29/20, 18:56 Completed build in 14m 44s on Wed, 29 Jan, 06:56 PM Test Summary: 70580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40339

  13. TYPO3com voted on patch set 5 V +1 01/29/20, 20:08 Completed build in 1h 42m 12s on Wed, 29 Jan, 08:08 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40339

  14. Benni Mack voted on patch set 5 V +1 CR +1 01/30/20, 12:16

  15. Susi Moog voted on patch set 5 V +2 CR +2 01/31/20, 10:04

  16. Susi Moog merged patch set 6 01/31/20, 10:04