Review main Merged

63063[BUGFIX] Use list module search in page module

Benni Mack CR +2 V +2 Hard +96 −651 updated 01/31/20, 11:12

Commit message

The page module search bar now redirects to the list module,
where all functionality is given, and all records on this
page (not just tt_content) are found, streamlining
it with the list module logic.

Editors without permission for the list module do not see
the search in the page module (similar behaviour to LiveSearch).

All code of the page layout classes related to search is removed.
As this is non-public API, the removal is done without any
deprecations necessary.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1341

Show 316 earlier messages
  1. Benni Mack uploaded patch set 1 01/28/20, 17:30

  2. TYPO3com voted on patch set 1 V -1 01/28/20, 17:30 Completed build in 15s on Tue, 28 Jan, 05:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40302

  3. Anja Leichsenring uploaded patch set 2 01/28/20, 17:49

  4. TYPO3com voted on patch set 2 V -1 01/28/20, 17:49 Completed build in 15s on Tue, 28 Jan, 05:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40303

  5. Anja Leichsenring uploaded patch set 3 01/28/20, 18:00

  6. TYPO3com voted on patch set 3 V -1 01/28/20, 18:01 Completed build in 34s on Tue, 28 Jan, 06:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  7. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 49m 16s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  8. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 49m 16s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  9. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 1h 01m 27s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  10. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 1h 25m 50s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  11. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 1h 25m 50s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  12. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 1h 13m 39s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  13. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 1h 50m 14s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  14. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 2h 02m 26s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  15. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 1h 50m 14s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  16. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 2h 14m 38s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  1. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 2h 26m 50s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  2. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 2h 39m 03s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  3. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 2h 51m 16s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  4. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 3h 03m 29s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  5. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 3h 15m 42s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  6. TYPO3com commented on patch set 3 01/28/20, 18:12 Completed build in 3h 15m 42s on Tue, 28 Jan, 06:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40304

  7. TYPO3com commented on patch set 3 01/28/20, 18:14 Completed build in 32s on Tue, 28 Jan, 06:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40305

  8. TYPO3com commented on patch set 3 01/28/20, 19:43 Completed build in 32s on Tue, 28 Jan, 07:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40306

  9. Georg Ringer commented on patch set 3 01/29/20, 05:39

    so what is if an editor doesn't have access to the list module?
  10. Benni Mack commented on patch set 3 01/29/20, 08:37

    > Patch Set 3: > > so what is if an editor doesn't have access to the list module? search is disabled then. Search now behaves similar to the „Show all results“ in the Live Search.
  11. Benni Mack updated the commit message in patch set 4 01/29/20, 08:37

  12. TYPO3com voted on patch set 4 V -1 01/29/20, 08:39 Completed build in 01m 59s on Wed, 29 Jan, 08:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40309

  13. TYPO3com commented on patch set 4 01/29/20, 09:58 Completed build in 1h 22m 09s on Wed, 29 Jan, 09:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40309

  14. TYPO3com commented on patch set 4 01/29/20, 12:41 Completed build in 5h 25m 57s on Wed, 29 Jan, 12:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40309

  15. Benni Mack uploaded patch set 5 01/29/20, 12:49

  16. TYPO3com voted on patch set 5 V -1 01/29/20, 12:52 Completed build in 29s on Wed, 29 Jan, 12:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40319

  17. Benni Mack uploaded patch set 6 01/30/20, 07:11

  18. TYPO3com voted on patch set 6 V -1 01/30/20, 07:18 Completed build in 24s on Thu, 30 Jan, 07:18 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40343

  19. Benni Mack uploaded patch set 7 01/30/20, 08:59

  20. TYPO3com voted on patch set 7 V -1 01/30/20, 09:23 Completed build in 17m 03s on Thu, 30 Jan, 09:23 AM Test Summary: 18 of 71290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40349

  21. Benni Mack uploaded patch set 8 01/30/20, 09:26

  22. TYPO3com voted on patch set 8 V +1 01/30/20, 09:49 Completed build in 22m 31s on Thu, 30 Jan, 09:49 AM Test Summary: 70821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40350

  23. Susi Moog voted on patch set 8 V +1 CR +1 01/31/20, 11:03

  24. Andreas Kienast voted on patch set 8 V +2 CR +2 01/31/20, 11:12

  25. Andreas Kienast merged patch set 9 01/31/20, 11:12