Review main Merged

63065[TASK] Respect extension state `excludeFromUpdates` during language updates

Georg Ringer CR +2 V +2 Easy +23 −0 updated 01/31/20, 11:39

Commit message

If the state property inside `ext_emconf.php` is set to `excludeFromUpdates`,
the extension will be skipped while updating the language files in the Install Tool.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Files 2

Review log 913

  1. Georg Ringer uploaded patch set 1 01/29/20, 11:59

  2. Georg Ringer uploaded patch set 2 01/29/20, 12:01

  3. Georg Ringer commented on patch set 2 01/29/20, 12:01

    This change is ready for review.
  4. TYPO3com voted on patch set 1 V +1 01/29/20, 12:12 Completed build in 12m 53s on Wed, 29 Jan, 12:12 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40313

  5. TYPO3com voted on patch set 2 V +1 01/29/20, 12:18 Completed build in 14m 53s on Wed, 29 Jan, 12:18 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40314

  6. Markus Klein commented on patch set 2 01/29/20, 14:43

    Important-90236-RespectExtensionStateExcludeFromUpdatesDuringLanguageUpdates.rst:15 Unresolved

    The sentence seems incomplete. "same ext key... as ...?"
  7. Susi Moog commented on patch set 3 01/31/20, 10:58

    Published edit on patch set 2.
  8. Susi Moog updated the commit message in patch set 4 01/31/20, 10:58

  9. TYPO3com voted on patch set 3 V +1 01/31/20, 11:10 Completed build in 12m 15s on Fri, 31 Jan, 11:10 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40395

  10. TYPO3com voted on patch set 4 V +1 01/31/20, 11:14 Completed build in 12m 35s on Fri, 31 Jan, 11:14 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40396

  11. Susi Moog voted on patch set 4 V +1 CR +1 01/31/20, 11:39

  12. Benni Mack voted on patch set 4 V +2 CR +2 01/31/20, 11:39

  13. Benni Mack merged patch set 5 01/31/20, 11:39