Review main Merged

63067[TASK] Simplify code of FileList module

Benni Mack CR +2 V +2 Hard +250 −568 updated 02/03/20, 08:08

Commit message

The FileList class was originally a derivative of DatabaseRecordList,
which was decoupled in TYPO3 v9 and and marked as internal.

It is responsible for showing the actual "FileList" in the TYPO3 Backend
module.

A lot of this code has grown historically, and can be removed and
simplified, as it is not directly connected to the abstract record list anymore.

This patch removes unused public properties like $JScode as this is
part of a "multi-table" setup as is possible in the database listings.

Some methods are split into smaller parts to make the methods
themselves smaller.

This is however just the first step, next to separating the curation
and the output (and moving this into a fluid template), also using proper pagination
for fetching files and folders, or building DI for the class now is much easier to do.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Susi Moog +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1116

  1. Benni Mack uploaded patch set 1 01/29/20, 12:47

  2. TYPO3com voted on patch set 1 V -1 01/29/20, 13:00 Completed build in 12m 55s on Wed, 29 Jan, 01:00 PM Test Summary: 70523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40318

  3. Oliver Klee commented on patch set 1 01/29/20, 13:01

    This change is quite big. Would it work to split it up (remove stuff and make things protected, another change set for types etc.)?

    TranslationConfigurationProvider.php:44 Unresolved

    The parameter should explictly be nullable (assuming that the @param is correct).

    FileList.php:217 Unresolved

    While we're changing the signature anyway, could we also add type annotations for the other parameters?
  4. Benni Mack commented on patch set 1 01/29/20, 13:48

    > Patch Set 1: > > (2 comments) > > This change is quite big. Would it work to split it up (remove stuff and make things protected, another change set for types etc.)? hmm, I could try to revert the type / signature part. This was a nice add-on but not important in this change right now.
  5. TYPO3com voted on patch set 1 V +1 01/30/20, 10:14 Completed build in 21h 39m 39s on Thu, 30 Jan, 10:14 AM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40318

  6. Benni Mack uploaded patch set 2 01/31/20, 10:12

  7. Susi Moog updated the commit message in patch set 3 01/31/20, 10:21

  8. TYPO3com voted on patch set 2 V +1 01/31/20, 10:24 Completed build in 11m 53s on Fri, 31 Jan, 10:24 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40385

  9. Benni Mack rebased onto patch set 4 01/31/20, 10:25

  10. TYPO3com voted on patch set 3 V +1 01/31/20, 10:33 Completed build in 11m 21s on Fri, 31 Jan, 10:33 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40388

  11. TYPO3com voted on patch set 4 V +1 01/31/20, 10:37 Completed build in 11m 56s on Fri, 31 Jan, 10:37 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40389

  12. Anja Leichsenring voted on patch set 4 V +1 CR +1 02/02/20, 08:16

  13. Guido Schmechel commented on patch set 4 02/02/20, 11:36

    FileList.php:282

    Isn't there also potential for simplification?
  14. Benni Mack commented on patch set 4 02/02/20, 16:28

    FileList.php:282 Reply Unresolved

    yeah, next step is to extract this piece of code in a custom pagination part.
  15. Susi Moog voted on patch set 4 V +2 CR +2 02/03/20, 08:08

  16. Susi Moog merged patch set 5 02/03/20, 08:08