63067[TASK] Simplify code of FileList module
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Susi Moog +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1116
-
Benni Mack uploaded patch set 1 01/29/20, 12:47
-
TYPO3com voted on patch set 1 V -1 01/29/20, 13:00 Completed build in 12m 55s on Wed, 29 Jan, 01:00 PM Test Summary: 70523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40318
-
Oliver Klee commented on patch set 1 01/29/20, 13:01
This change is quite big. Would it work to split it up (remove stuff and make things protected, another change set for types etc.)?TranslationConfigurationProvider.php:44UnresolvedThe parameter should explictly be nullable (assuming that the @param is correct).FileList.php:217UnresolvedWhile we're changing the signature anyway, could we also add type annotations for the other parameters? -
Benni Mack commented on patch set 1 01/29/20, 13:48
> Patch Set 1: > > (2 comments) > > This change is quite big. Would it work to split it up (remove stuff and make things protected, another change set for types etc.)? hmm, I could try to revert the type / signature part. This was a nice add-on but not important in this change right now. -
TYPO3com voted on patch set 1 V +1 01/30/20, 10:14 Completed build in 21h 39m 39s on Thu, 30 Jan, 10:14 AM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40318
-
Benni Mack uploaded patch set 2 01/31/20, 10:12
-
Susi Moog updated the commit message in patch set 3 01/31/20, 10:21
-
TYPO3com voted on patch set 2 V +1 01/31/20, 10:24 Completed build in 11m 53s on Fri, 31 Jan, 10:24 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40385
-
Benni Mack rebased onto patch set 4 01/31/20, 10:25
-
TYPO3com voted on patch set 3 V +1 01/31/20, 10:33 Completed build in 11m 21s on Fri, 31 Jan, 10:33 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40388
-
TYPO3com voted on patch set 4 V +1 01/31/20, 10:37 Completed build in 11m 56s on Fri, 31 Jan, 10:37 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40389
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 02/02/20, 08:16
-
Guido Schmechel commented on patch set 4 02/02/20, 11:36
FileList.php:282Isn't there also potential for simplification? -
Benni Mack commented on patch set 4 02/02/20, 16:28
FileList.php:282Reply Unresolvedyeah, next step is to extract this piece of code in a custom pagination part. -
Susi Moog voted on patch set 4 V +2 CR +2 02/03/20, 08:08
-
Susi Moog merged patch set 5 02/03/20, 08:08