63068[BUGFIX] Avoid PHP notices in unit tests
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oliver Klee +1
-
Verified V +2 Done
- Oliver Hader +2
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Security/EmailLoginNotification.php1+1 −1
- typo3/sysext/backend/Tests/Unit/Http/RouteDispatcherTest.php+9 −18
- typo3/sysext/core/Classes/Information/Typo3Information.php1+1 −1
- typo3/sysext/core/Classes/Routing/PageRouter.php2+2 −2
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php1+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+10 −2
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/TreeDataProviderFactoryTest.php+1 −1
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php5+4 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/EmConfUtilityTest.php1+4 −4
Review log 1620
-
Benni Mack uploaded patch set 1 01/29/20, 14:05
-
Oliver Klee commented on patch set 1 01/29/20, 14:11
Typo3Information.php:40UnresolvedAs this is an object, I'd propose to use null as the fallback, not an empty string.PageRouter.php:514UnresolvedWhat types does the array contain? (The fallback should be of the same type.)ExtensionManagementService.php:319UnresolvedIf the array element is not set, does it make sense to continue here at all, or should we make this a guard clause with an early return instead?EmConfUtilityTest.php:60UnresolvedI feel honored. ;-) -
TYPO3com voted on patch set 1 V +1 01/29/20, 14:18 Completed build in 12m 55s on Wed, 29 Jan, 02:18 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40322
-
Benni Mack uploaded patch set 2 01/29/20, 15:07
-
Benni Mack commented on patch set 1 01/29/20, 15:08
Thanks for the feedback, I incorporated your questions and made all code more clear, as you proposed. Thanks! -
Oliver Klee commented on patch set 2 CR +1 01/29/20, 15:23
Neat! -
TYPO3com voted on patch set 2 V +1 01/29/20, 15:29 Completed build in 20m 58s on Wed, 29 Jan, 03:29 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40327
-
Oliver Hader commented on patch set 2 01/29/20, 16:31
PageRouter.php:242UnresolvedShould not have had any effect... did it?LegacyLinkNotationConverterTest.php:307UnresolvedNice, PHP 7.4 compatExtensionManagementService.php:320singular $path, correct? -
Oliver Hader uploaded patch set 3 01/29/20, 18:20
-
Oliver Hader voted on patch set 3 V +1 CR +1 01/29/20, 18:21
-
Oliver Hader commented on patch set 3 01/29/20, 18:23
ExtensionManagementService.php:320Reply UnresolvedMoved it up... if $paths are empty, $path is as well, thus settings the property is avoided -
Oliver Klee commented on patch set 3 CR -1 01/29/20, 18:28
ExtensionManagementService.php:323My initial comment referred to the case where $path is an empty string, and where it might not make sense to execute the lines after line 322. So it should the empty check should be fore $path, not $paths, and the check should be after the line where $path is set to an empty string. -
TYPO3com voted on patch set 3 V +1 01/29/20, 18:33 Completed build in 12m 02s on Wed, 29 Jan, 06:33 PM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40337
-
Oliver Hader commented on patch set 3 01/29/20, 18:34
ExtensionManagementService.php:323Reply UnresolvedSorry, I overlooked that comment... -
Oliver Hader uploaded patch set 4 01/29/20, 18:35
-
Oliver Hader voted on patch set 4 V +1 CR +1 01/29/20, 18:36
-
TYPO3com voted on patch set 4 V +1 01/29/20, 18:48 Completed build in 13m 10s on Wed, 29 Jan, 06:48 PM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40338
-
Oliver Hader voted on patch set 4 V +2 CR +2 01/29/20, 19:43
-
Oliver Hader merged patch set 5 01/29/20, 19:43
-
Oliver Klee voted on patch set 5 CR +1 01/29/20, 21:35
EmailLoginNotification.php:106Unresolved