Review main Merged

63069[TASK] Remove unused code from PageLayoutView

Benni Mack CR +2 V +2 Hard +49 −478 updated 01/31/20, 12:26

Commit message

Until TYPO3 v9, PageLayoutView was a subclass of AbstractDatabaseRecordList,
so it inherited a lot of logic, which was never used in this class.

The code can safely be removed, as PageLayoutView is only used
in Page Module (web_layout) and Info Module ("Page Information").

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Benni Mack uploaded patch set 1 01/29/20, 14:48

  2. TYPO3com voted on patch set 1 V -1 01/29/20, 15:00 Completed build in 12m 02s on Wed, 29 Jan, 03:00 PM Test Summary: 8 of 71268 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40324

  3. Benni Mack uploaded patch set 2 01/29/20, 15:03

  4. TYPO3com voted on patch set 2 V +1 01/29/20, 15:16 Completed build in 12m 36s on Wed, 29 Jan, 03:16 PM Test Summary: 70828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40325

  5. Oliver Hader commented on patch set 2 CR +1 01/29/20, 19:07

    PageLayoutController.php:757 Unresolved

    I was unsure about this one, but checked call hierarchy which points back to invocation in PageLayoutController and PageInformationController
  6. Oliver Hader voted on patch set 2 V +1 01/29/20, 19:24

  7. Georg Ringer voted on patch set 2 V +2 CR +2 01/30/20, 05:32

  8. Georg Ringer merged patch set 3 01/30/20, 05:32

  9. Claus Due commented on patch set 3 01/31/20, 12:01

    I'd like to request that we all become a bit more conservative about changing method signatures when it isn't strictly necessary. This change breaks Flux compatibility and will now require two different classes for operation on different TYPO3 versions.

    PageLayoutView.php:1448 Unresolved

    Isn't this a breaking change - the method isn't marked as @internal. Flux for example uses this method and will break after applying this patch: https://github.com/FluidTYPO3/flux/blob/development/Classes/Integration/Overrides/PageLayoutView.php#L65

    PageLayoutView.php:1754 Unresolved

    This method is public and the signature is now changed, does this not make the change a breaking change?
  10. Claus Due commented on patch set 3 01/31/20, 12:26