Review main Merged

63070[TASK] Make RteHtmlParser entrypoint API cleaner

Benni Mack CR +2 V +2 Hard +204 −162 updated 01/31/20, 17:01

Commit message

The RteHtmlParser has two public methods:
->init()
->RTE_transform()

init() was introduced in early PHP4 times when there was no constructor in PHP.
RTE_transform() contained a lot of parsing of properties, which is not needed
anymore since TYPO3 v8. init() itself is not needed anymore.

Since TYPO3 v8, RteHtmlParser is much cleaner towards the developer,
and the last step for this PHP class is to clearly separate the logic for the transformations in each direction, making two new entrypoints:
->transformTextForRichTextEditor($content, $configuration)
->transformTextForPersistence($content, $configuration)

This way, all logic is separated in these two methods, and the existing
RTE_transform() method is just a shell, which is not needed anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 811

  1. Benni Mack uploaded patch set 1 01/29/20, 16:06

  2. TYPO3com voted on patch set 1 V -1 01/29/20, 16:30 Completed build in 15m 24s on Wed, 29 Jan, 04:30 PM Test Summary: 7 of 71291 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40333

  3. Benni Mack uploaded patch set 2 01/30/20, 12:10

  4. TYPO3com voted on patch set 2 V +1 01/30/20, 12:20 Completed build in 10m 05s on Thu, 30 Jan, 12:20 PM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40352

  5. Benni Mack uploaded patch set 3 01/30/20, 14:10

  6. TYPO3com voted on patch set 3 V +1 01/30/20, 14:20 Completed build in 10m 17s on Thu, 30 Jan, 02:20 PM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40364

  7. Susi Moog voted on patch set 3 V +1 CR +1 01/31/20, 16:04

  8. Daniel Goerz voted on patch set 3 V +1 01/31/20, 16:24

  9. Oliver Hader voted on patch set 3 CR +1 01/31/20, 17:00

  10. Benni Mack voted on patch set 3 V +2 CR +2 01/31/20, 17:00

  11. Benni Mack merged patch set 4 01/31/20, 17:01