63071[BUGFIX] No longer use deprecated function writeDeprecationLogFileEntry
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Jonas Eberle +1
- Johannes Seipelt +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Jonas Eberle +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1418
-
Sybille Peters uploaded patch set 1 01/29/20, 18:03
-
TYPO3com voted on patch set 1 V -1 01/29/20, 18:16 Completed build in 12m 24s on Wed, 29 Jan, 06:16 PM Test Summary: 73777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1930
-
TYPO3com voted on patch set 1 V +1 01/29/20, 18:59 Completed build in 12m 03s on Wed, 29 Jan, 06:59 PM Test Summary: 74222 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1931
-
TYPO3com commented on patch set 1 01/29/20, 19:05 Completed build in 18m 11s on Wed, 29 Jan, 07:05 PM Test Summary: 74222 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1932
-
Guido Schmechel voted on patch set 1 CR +1 02/01/20, 13:20
-
Daniel Haupt voted on patch set 1 V +1 CR +1 02/02/20, 17:31
-
Susi Moog commented on patch set 1 CR -1 02/28/20, 05:40
Just from reading the code: shouldn't the same then be done for all other calls that still write the file? (for example logDeprecatedViewHelperAttribute, getDeprecationLogFileName ...) -
Sybille Peters commented on patch set 1 02/28/20, 07:14
Yes, there are 3 more in GeneralUtility. -
Sybille Peters uploaded patch set 2 03/21/20, 16:09
-
Sybille Peters commented on patch set 2 03/21/20, 16:09
> Patch Set 1: Code-Review-1 > > Just from reading the code: shouldn't the same then be done for all other calls that still write the file? (for example logDeprecatedViewHelperAttribute, getDeprecationLogFileName ...) Replaced all occurences of writeDeprecationLogFileEntry() -
TYPO3com voted on patch set 2 V +1 03/21/20, 16:21 Completed build in 11m 49s on Sat, 21 Mar, 04:21 PM Test Summary: 74442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-306
-
Jonas Eberle voted on patch set 2 V +1 CR +1 03/28/20, 23:18
-
Johannes Seipelt voted on patch set 2 CR +1 04/28/20, 09:35
-
Josef Glatz voted on patch set 2 V +1 CR +1 04/28/20, 10:37
-
Benni Mack voted on patch set 2 V +2 CR +2 04/28/20, 15:21
-
Benni Mack merged patch set 3 04/28/20, 15:21
-
Markus Klein commented on patch set 3 04/28/20, 18:25
GeneralUtility.php:4095Missing E_USER_DEPRECATED? -
Markus Klein commented on patch set 3 04/28/20, 18:35
GeneralUtility.php:4095Reply Unresolved