Review 9.5 Merged

63071[BUGFIX] No longer use deprecated function writeDeprecationLogFileEntry

Sybille Peters CR +2 V +2 Easy +4 −4 updated 04/28/20, 18:35

Commit message

The function writeDeprecationLogFileEntry has been deprecated
in TYPO3 9.

When a deprecated function is called, we now use trigger_error()
using E_USER_DEPRECATED to warn about deprecated functionality.

Not only is writeDeprecationLogFileEntry() deprecated, but calling
this function resulted in the deprecation being logged to the static
file var/log/deprecation_*.log. This logging is not configurable.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Jonas Eberle +1
    • Johannes Seipelt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1418

  1. Sybille Peters uploaded patch set 1 01/29/20, 18:03

  2. TYPO3com voted on patch set 1 V -1 01/29/20, 18:16 Completed build in 12m 24s on Wed, 29 Jan, 06:16 PM Test Summary: 73777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1930

  3. TYPO3com voted on patch set 1 V +1 01/29/20, 18:59 Completed build in 12m 03s on Wed, 29 Jan, 06:59 PM Test Summary: 74222 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1931

  4. TYPO3com commented on patch set 1 01/29/20, 19:05 Completed build in 18m 11s on Wed, 29 Jan, 07:05 PM Test Summary: 74222 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1932

  5. Guido Schmechel voted on patch set 1 CR +1 02/01/20, 13:20

  6. Daniel Haupt voted on patch set 1 V +1 CR +1 02/02/20, 17:31

  7. Susi Moog commented on patch set 1 CR -1 02/28/20, 05:40

    Just from reading the code: shouldn't the same then be done for all other calls that still write the file? (for example logDeprecatedViewHelperAttribute, getDeprecationLogFileName ...)
  8. Sybille Peters commented on patch set 1 02/28/20, 07:14

    Yes, there are 3 more in GeneralUtility.
  9. Sybille Peters uploaded patch set 2 03/21/20, 16:09

  10. Sybille Peters commented on patch set 2 03/21/20, 16:09

    > Patch Set 1: Code-Review-1 > > Just from reading the code: shouldn't the same then be done for all other calls that still write the file? (for example logDeprecatedViewHelperAttribute, getDeprecationLogFileName ...) Replaced all occurences of writeDeprecationLogFileEntry()
  11. TYPO3com voted on patch set 2 V +1 03/21/20, 16:21 Completed build in 11m 49s on Sat, 21 Mar, 04:21 PM Test Summary: 74442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-306

  12. Jonas Eberle voted on patch set 2 V +1 CR +1 03/28/20, 23:18

  13. Johannes Seipelt voted on patch set 2 CR +1 04/28/20, 09:35

  14. Josef Glatz voted on patch set 2 V +1 CR +1 04/28/20, 10:37

  15. Benni Mack voted on patch set 2 V +2 CR +2 04/28/20, 15:21

  16. Benni Mack merged patch set 3 04/28/20, 15:21

  17. Markus Klein commented on patch set 3 04/28/20, 18:25

    GeneralUtility.php:4095

    Missing E_USER_DEPRECATED?
  18. Markus Klein commented on patch set 3 04/28/20, 18:35

    GeneralUtility.php:4095 Reply Unresolved