Review main Abandoned

63074[TASK] Streamline TSFE usage of getPageAndRootlineWithDomain

Benni Mack CR 0 V 0 Normal +28 −25 updated 02/20/20, 21:36

Commit message

The TSFE functionality getPageAndRootlineWithDomain() - a method marked
as internal - actually modifies the rootline, AND it fetches the rootline as well before.

This is not needed, and as such - the method name is changed to
"adaptRootLineIfPageIsNotInSite()". and the getPageAndRootline() method
is moved outside of the method.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1419

  1. Benni Mack uploaded patch set 1 01/30/20, 12:24

  2. Oliver Klee commented on patch set 1 01/30/20, 12:33

    Unresolved

    Is this still WIP?
  3. TYPO3com voted on patch set 1 V -1 01/30/20, 12:37 Completed build in 12m 20s on Thu, 30 Jan, 12:37 PM Test Summary: 24 of 71290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40355

  4. Benni Mack updated the commit message in patch set 2 01/30/20, 12:56

  5. Benni Mack commented on patch set 2 01/30/20, 12:56

    Thanks, Oli! Just forget the issue number. Rest is ready to review.
  6. TYPO3com voted on patch set 2 V -1 01/30/20, 13:06 Completed build in 10m 49s on Thu, 30 Jan, 01:06 PM Test Summary: 24 of 71290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40357

  7. Benni Mack uploaded patch set 3 01/30/20, 13:11

  8. TYPO3com voted on patch set 3 V -1 01/30/20, 13:21 Completed build in 10m 00s on Thu, 30 Jan, 01:21 PM Test Summary: 70839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40359

  9. Oliver Klee commented on patch set 3 01/30/20, 13:22

    CanonicalGeneratorTest.php:60

    Why the switch from new to makeInstance here? In general, GeneralUtility::makeInstance should only be used in tests where some feature of makeInstance is required (e.g., the singleton property). In all other cases, new should be used (as the test usually is not about makeInstance and should not depend on makeInstance).
  10. Benni Mack commented on patch set 3 01/30/20, 13:53

    CanonicalGeneratorTest.php:60 Reply Unresolved

    TypoScriptFrontendController needs a logger. But I could do this with setLogger()
  11. Benni Mack uploaded patch set 4 01/30/20, 14:03

  12. TYPO3com voted on patch set 4 V +1 01/30/20, 14:13 Completed build in 09m 42s on Thu, 30 Jan, 02:13 PM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40363

  13. Oliver Hader voted on patch set 4 CR +1 01/30/20, 21:02

  14. Oliver Hader voted on patch set 4 V +1 01/30/20, 21:05

  15. Susi Moog commented on patch set 4 V -1 01/31/20, 08:38

    TypoScriptFrontendController.php:2711

    if I understand that setting correctly, the condition should be inverted, as currently it adapts the root line if content is allowed from outside. Additionally however I was not able to make any kind of difference with that setting. Disallowing results in contentPid set (correctly) to the start page of my current site, however content from the "show content from this page"-other-site is still displayed ?!
  16. Benni Mack commented on patch set 4 01/31/20, 09:28

    TypoScriptFrontendController.php:2711 Reply Unresolved

    content from this page is still displayed as $this->contentPid is set. But you're right the setting needs to be inverted
  17. Benni Mack commented on patch set 5 01/31/20, 09:32

    Published edit on patch set 4.
  18. TYPO3com voted on patch set 5 V +1 01/31/20, 09:49 Completed build in 16m 33s on Fri, 31 Jan, 09:49 AM Test Summary: 70838 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40384

  19. Benni Mack abandoned the change 02/20/20, 21:36

    not needed anymore right now