63075[TASK] Deprecate $ref param types of method callUserFunction
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Benni Mack +1
-
Verified V +2 Done
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1725
-
Alexander Schnitzler uploaded patch set 1 01/30/20, 12:52
-
Alexander Schnitzler commented on patch set 1 01/30/20, 12:54
This change is ready for review. -
Alexander Schnitzler marked it work in progress 01/30/20, 12:54
-
TYPO3com voted on patch set 1 V -1 01/30/20, 13:02 Completed build in 10m 23s on Thu, 30 Jan, 01:02 PM Test Summary: 48 of 71290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40356
-
TYPO3com commented on patch set 1 01/30/20, 13:10 Completed build in 28m 54s on Thu, 30 Jan, 01:10 PM Test Summary: 48 of 71290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40356
-
Alexander Schnitzler uploaded patch set 2 01/30/20, 13:14
-
TYPO3com voted on patch set 2 V +1 01/30/20, 13:29 Completed build in 14m 54s on Thu, 30 Jan, 01:29 PM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40360
-
Alexander Schnitzler uploaded patch set 3 01/30/20, 16:04
-
Alexander Schnitzler updated the commit message in patch set 4 01/30/20, 16:05
-
TYPO3com voted on patch set 3 V -1 01/30/20, 16:08 Completed build in 03m 47s on Thu, 30 Jan, 04:08 PM Test Summary: 3 of 382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40369
-
TYPO3com voted on patch set 4 V -1 01/30/20, 16:09 Completed build in 03m 32s on Thu, 30 Jan, 04:09 PM Test Summary: 3 of 382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40370
-
Alexander Schnitzler uploaded patch set 5 01/30/20, 16:12
-
TYPO3com voted on patch set 5 V +1 01/30/20, 16:21 Completed build in 09m 21s on Thu, 30 Jan, 04:21 PM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40371
-
Alexander Schnitzler uploaded patch set 6 02/15/20, 12:09
-
TYPO3com voted on patch set 6 V +1 02/15/20, 12:23 Completed build in 14m 46s on Sat, 15 Feb, 12:23 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-111
-
Alexander Schnitzler commented on patch set 6 02/15/20, 12:27
This change is ready for review.GeneralUtility.php:3354As we explicitly allow null, we could use a default value here as well. wdyt? -
Susi Moog commented on patch set 6 02/22/20, 18:36
GeneralUtility.php:3354Reply Unresolveddefault null sounds good to me. explicitly passing null is unnecessary in this case I think. -
Alexander Schnitzler commented on patch set 6 CR -1 02/22/20, 19:02
If we merge this, we need to remove the ignored error in phpstan.neon -
Alexander Schnitzler commented on patch set 6 CR 0 02/23/20, 08:52
> Patch Set 6: Code-Review-1 > > If we merge this, we need to remove the ignored error in phpstan.neon I commented the wrong patch... -
Alexander Schnitzler uploaded patch set 7 02/26/20, 18:53
-
TYPO3com voted on patch set 7 V +1 02/26/20, 19:03 Completed build in 09m 26s on Wed, 26 Feb, 07:03 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-723
-
Benni Mack commented on patch set 7 02/27/20, 12:52
nice one. with this, we could actually then spot all the places where "null" is handed in and not hand in anything anymore ;) -
Benni Mack voted on patch set 7 V +1 CR +1 02/27/20, 12:52
-
Susi Moog voted on patch set 7 V +2 CR +2 02/27/20, 13:03
-
Susi Moog merged patch set 8 02/27/20, 13:03