63076[TASK] Replace ResourceFactory::getInstance() with makeInstance
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
- TYPO3com +1 CI
Issues 1
Files 62
- typo3/sysext/backend/Classes/Backend/Avatar/DefaultAvatarProvider.php+1 −1
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+1 −1
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+3 −3
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/ThumbnailController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/ImageManipulationController.php+1 −1
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaGroup.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+2 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+2 −1
- typo3/sysext/core/Classes/Compatibility/SlotReplacement.php+2 −2
- typo3/sysext/core/Classes/Controller/FileDumpController.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/Resource/Collection/CategoryBasedFileCollection.php+1 −1
- typo3/sysext/core/Classes/Resource/Filter/FileExtensionFilter.php+1 −1
Show 42 more files
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+1 −1
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php+1 −1
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/FolderMountsRestriction.php+2 −1
- typo3/sysext/core/Classes/Resource/Search/Result/FileSearchResult.php+2 −1
- typo3/sysext/core/Classes/Resource/Security/FileMetadataPermissionsAspect.php+2 −1
- typo3/sysext/core/Classes/Resource/File.php+1 −1
- typo3/sysext/core/Classes/Resource/FileReference.php+2 −2
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+4 −2
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+2 −2
- typo3/sysext/core/Classes/ServiceProvider.php+8 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-90260-ResourceFactorygetInstancePseudo-factory.rstnew+42 −0
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+6 −6
- typo3/sysext/extbase/Classes/Domain/Model/File.php+4 −1
- typo3/sysext/extbase/Classes/Domain/Model/FileReference.php+4 −1
- typo3/sysext/extbase/Classes/Service/ImageService.php+1 −1
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+3 −3
- typo3/sysext/filelist/Classes/Controller/File/CreateFolderController.php+1 −1
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+1 −1
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.php+1 −1
- typo3/sysext/filelist/Classes/Controller/File/RenameFileController.php+2 −1
- typo3/sysext/filelist/Classes/Controller/File/ReplaceFileController.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php+1 −1
- typo3/sysext/form/Tests/Functional/Hooks/FormFileExtensionUpdateTest.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+5 −5
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+2 −2
- typo3/sysext/impexp/Classes/Controller/ImportController.php+1 −1
- typo3/sysext/impexp/Classes/Export.php+2 −2
- typo3/sysext/impexp/Classes/Import.php+8 −8
- typo3/sysext/impexp/Classes/ImportExport.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/FolderBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php+1 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionTask.php+5 −2
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.php+4 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingTask.php+5 −2
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
- typo3/sysext/t3editor/Classes/Hook/FileEditHook.php+1 −1
Review log 811
-
Benni Mack uploaded patch set 1 01/30/20, 15:20
-
TYPO3com voted on patch set 1 V +1 01/30/20, 15:30 Completed build in 09m 11s on Thu, 30 Jan, 03:30 PM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40367
-
Benni Mack uploaded patch set 2 01/30/20, 15:49
-
TYPO3com voted on patch set 2 V -1 01/30/20, 15:59 Completed build in 09m 42s on Thu, 30 Jan, 03:59 PM Test Summary: 70387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40368
-
TYPO3com voted on patch set 2 V +1 01/30/20, 16:05 Completed build in 26m 08s on Thu, 30 Jan, 04:05 PM Test Summary: 70838 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40368
-
Oliver Hader voted on patch set 2 V +1 CR +1 01/30/20, 20:41
-
Oliver Hader commented on patch set 2 V +2 CR +2 01/30/20, 20:42
Pretty straight forward... -
Oliver Hader merged patch set 3 01/30/20, 20:42
-
Benjamin Franzke commented on patch set 3 01/30/20, 21:29
> Pretty straight forward... Well, just wanted to vote and add a "Resolves" line which documents that this patch fixes https://forge.typo3.org/issues/89891 due to implicitly adding a factory for the installtool. That factory ensured ResourceFactory can always be created, even in installtool and therefore fixes assets cleanups. Anyway, I marked the mentioned bug as resolved. -
Oliver Hader commented on patch set 3 01/30/20, 21:30
> Patch Set 3: > > > Pretty straight forward... > Well, just wanted to vote and add a "Resolves" line which documents that this patch fixes https://forge.typo3.org/issues/89891 due to implicitly adding a factory for the installtool. > That factory ensured ResourceFactory can always be created, even in installtool and therefore fixes assets cleanups. > > Anyway, I marked the mentioned bug as resolved. Thanks for taking care! -
Oliver Hader commented on patch set 3 01/30/20, 21:31
... and it's still possible to vote