Review main Merged

63076[TASK] Replace ResourceFactory::getInstance() with makeInstance

Benni Mack CR +2 V +2 Hard +167 −88 updated 01/30/20, 21:31

Commit message

The so-called "singleton factory instance" is a wrapper around makeInstance
which can be used directly anyways.

With Dependency Injection this is not even necessary anymore, and should
be avoided under all circumstances.

The constructor does not cache anything, so this can be replaced completely.

SingletonInterface + DI should be sufficient already.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 62

Show 42 more files

Review log 811

  1. Benni Mack uploaded patch set 1 01/30/20, 15:20

  2. TYPO3com voted on patch set 1 V +1 01/30/20, 15:30 Completed build in 09m 11s on Thu, 30 Jan, 03:30 PM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40367

  3. Benni Mack uploaded patch set 2 01/30/20, 15:49

  4. TYPO3com voted on patch set 2 V -1 01/30/20, 15:59 Completed build in 09m 42s on Thu, 30 Jan, 03:59 PM Test Summary: 70387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40368

  5. TYPO3com voted on patch set 2 V +1 01/30/20, 16:05 Completed build in 26m 08s on Thu, 30 Jan, 04:05 PM Test Summary: 70838 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40368

  6. Oliver Hader voted on patch set 2 V +1 CR +1 01/30/20, 20:41

  7. Oliver Hader commented on patch set 2 V +2 CR +2 01/30/20, 20:42

    Pretty straight forward...
  8. Oliver Hader merged patch set 3 01/30/20, 20:42

  9. Benjamin Franzke commented on patch set 3 01/30/20, 21:29

    > Pretty straight forward... Well, just wanted to vote and add a "Resolves" line which documents that this patch fixes https://forge.typo3.org/issues/89891 due to implicitly adding a factory for the installtool. That factory ensured ResourceFactory can always be created, even in installtool and therefore fixes assets cleanups. Anyway, I marked the mentioned bug as resolved.
  10. Oliver Hader commented on patch set 3 01/30/20, 21:30

    > Patch Set 3: > > > Pretty straight forward... > Well, just wanted to vote and add a "Resolves" line which documents that this patch fixes https://forge.typo3.org/issues/89891 due to implicitly adding a factory for the installtool. > That factory ensured ResourceFactory can always be created, even in installtool and therefore fixes assets cleanups. > > Anyway, I marked the mentioned bug as resolved. Thanks for taking care!
  11. Oliver Hader commented on patch set 3 01/30/20, 21:31

    ... and it's still possible to vote