Review main Merged

63077[FEATURE] Add Argon2id to password hash algorithms

Gerrit Mohrmann CR +2 V +2 Hard +575 −137 updated 02/23/20, 11:28

Commit message

This adds Argon2id to the password hash algorithms. It should be
available since PHP 7.3.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 2534

Show 59 earlier messages
  1. Gerrit Mohrmann uploaded patch set 1 01/30/20, 16:32

  2. TYPO3com voted on patch set 1 V -1 01/30/20, 16:42 Completed build in 09m 14s on Thu, 30 Jan, 04:42 PM Test Summary: 4064 of 71374 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40372

  3. Gerrit Mohrmann uploaded patch set 2 01/30/20, 17:05

  4. TYPO3com voted on patch set 2 V -1 01/30/20, 17:14 Completed build in 09m 25s on Thu, 30 Jan, 05:14 PM Test Summary: 660 of 71374 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40373

  5. Gerrit Mohrmann uploaded patch set 3 01/31/20, 17:09

  6. TYPO3com voted on patch set 3 V -1 01/31/20, 17:27 Completed build in 12m 43s on Fri, 31 Jan, 05:27 PM Test Summary: 20 of 71716 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40437

  7. Gerrit Mohrmann uploaded patch set 4 01/31/20, 19:00

  8. TYPO3com voted on patch set 4 V +1 01/31/20, 19:09 Completed build in 09m 46s on Fri, 31 Jan, 07:09 PM Test Summary: 71238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40440

  9. Anja Leichsenring voted on patch set 4 V +1 CR +1 02/13/20, 10:26

  1. Anja Leichsenring rebased onto patch set 5 02/13/20, 10:26

  2. Anja Leichsenring voted on patch set 5 V +1 CR +1 02/13/20, 10:26

  3. Benni Mack commented on patch set 5 02/13/20, 10:36

    Should we really use Argon2id as default? I felt this was very cumbersome (in terms of communication of support), so we would fall in the same trap: - Live server has PHP 7.2 - local is PHP 7.3 - deployment to live - nobody can log in => I know it's a deployment problem, but still PITA for everybody. What do you think of having the option available but not active by default, but showing this in Install Tool or Status Report if it is available (and then - only in production :D) ?
  4. Rudy Gnodde voted on patch set 5 CR +1 02/13/20, 10:42

  5. TYPO3com voted on patch set 5 V +1 02/13/20, 10:42 Completed build in 15m 18s on Thu, 13 Feb, 10:42 AM Test Summary: 71318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36

  6. TYPO3com commented on patch set 5 02/13/20, 10:49 Completed build in 15m 36s on Thu, 13 Feb, 10:49 AM Test Summary: 71318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37

  7. Gerrit Mohrmann uploaded patch set 6 02/15/20, 15:15

  8. Gerrit Mohrmann commented on patch set 6 02/15/20, 15:20

    > What do you think of having the option available but not active by default, but showing this in Install Tool or Status Report if it is available (and then - only in production :D) ? Have removed the default, and added some hint in the install tool preset information.
  9. TYPO3com voted on patch set 6 V +1 02/15/20, 15:29 Completed build in 13m 58s on Sat, 15 Feb, 03:29 PM Test Summary: 71351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-124

  10. Anja Leichsenring voted on patch set 6 V +1 CR +1 02/15/20, 19:19

  11. Susi Moog commented on patch set 6 CR -1 02/21/20, 08:24

    on it, messages are a bit weird at the moment. will fix.
  12. Susi Moog uploaded patch set 7 02/21/20, 08:40

  13. TYPO3com voted on patch set 7 V +1 02/21/20, 09:35 Completed build in 50m 33s on Fri, 21 Feb, 09:35 AM Test Summary: 71520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-386

  14. Susi Moog voted on patch set 7 V +1 CR +1 02/21/20, 09:45

  15. Daniel Goerz voted on patch set 7 CR +1 02/21/20, 12:58

  16. Markus Klein commented on patch set 7 02/21/20, 13:59

    AbstractArgon2PasswordHash.php:158

    can be simplified to return isset($passwordInfo['algo']) && $passwordInfo['algo'] === $this->getPasswordAlgorithm() && strncmp($saltedPW, static::PREFIX, strlen(static::PREFIX)) === 0;
  17. Markus Klein commented on patch set 7 02/21/20, 14:00

    DefaultConfigurationDescription.yaml:528

    Why is it first position here and second above?
  18. Gerrit Mohrmann uploaded patch set 8 02/21/20, 19:26

  19. Gerrit Mohrmann commented on patch set 8 02/21/20, 19:35

    AbstractArgon2PasswordHash.php:158 Reply

    Done

    DefaultConfigurationDescription.yaml:528 Reply

    Done
  20. TYPO3com voted on patch set 8 V +1 02/21/20, 19:54 Completed build in 19m 21s on Fri, 21 Feb, 07:54 PM Test Summary: 71532 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-429

  21. Susi Moog voted on patch set 8 V +1 CR +1 02/22/20, 15:02

  22. Andreas Kienast voted on patch set 8 V +2 CR +2 02/22/20, 17:06

  23. Andreas Kienast merged patch set 9 02/22/20, 17:06

  24. Alexander Schnitzler commented on patch set 9 02/23/20, 10:50

    Post -1: Accessing non existing class constants in AbstractArgon2PasswordHash, which are only possibly available through late static binding, is bad architecture in my opinion. We must start to think in interfaces instead. An interface can define methods that return the values that are now implemented as constants. The abstract class can rely on the concrete implementation implementing those methods. The idea of constants is totally absurd in this scenario. Late static binding hasn't been introduced for that kind of magic.
  25. Alexander Schnitzler commented on patch set 9 02/23/20, 11:28