Review main Merged

63078[TASK] Use correct regexp character class

Oliver Hader CR +2 V +2 Easy +2 −2 updated 01/31/20, 10:48

Commit message

Use [:xdigit:] (a-f0-9/i) instead of [:alnum:] (a-z0-9/i)
for parsing hexadecimal values in sequences.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Oliver Hader uploaded patch set 1 01/30/20, 21:19

  2. TYPO3com voted on patch set 1 V -1 01/30/20, 21:31 Completed build in 12m 19s on Thu, 30 Jan, 09:31 PM Test Summary: 70535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40374

  3. TYPO3com voted on patch set 1 V +1 01/31/20, 09:32 Completed build in 12h 25m 17s on Fri, 31 Jan, 09:32 AM Test Summary: 70840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40374

  4. Andreas Kienast voted on patch set 1 CR +1 01/31/20, 09:51

  5. Susi Moog voted on patch set 1 V +1 CR +1 01/31/20, 10:10

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 01/31/20, 10:13

  7. Andreas Kienast merged patch set 2 01/31/20, 10:13

  8. Oliver Klee commented on patch set 2 01/31/20, 10:48

    Should we also fix this in 9.5 and 8.7?